Remove dialect instantiation in AddDeserializedMapping

Author: hazzik

src/NHibernate.Test/CfgTest/ConfigurationAddMappingEvents.cs

@@ -53,7 +53,6 @@ public void WhenSubscribedToBeforeBindThenRaiseEventForEachMapping()
 			Assert.That(listOfCalls.Count, Is.EqualTo(2));
 			Assert.That(listOfCalls.Select(x => x.FileName).All(x => x != null), Is.True);
 			Assert.That(listOfCalls.Select(x => x.Mapping).All(x => x != null), Is.True);
-			Assert.That(listOfCalls.Select(x => x.Dialect).All(x => x.GetType() == typeof (MsSql2008Dialect)), Is.True);
 		}
 
 		[Test]
@@ -70,7 +69,6 @@ public void WhenSubscribedToAfterBindThenRaiseEventForEachMapping()
 			Assert.That(listOfCalls.Count, Is.EqualTo(2));
 			Assert.That(listOfCalls.Select(x => x.FileName).All(x => x != null), Is.True);
 			Assert.That(listOfCalls.Select(x => x.Mapping).All(x => x != null), Is.True);
-			Assert.That(listOfCalls.Select(x => x.Dialect).All(x => x.GetType() == typeof(MsSql2008Dialect)), Is.True);
 		}
 	}
 }

src/NHibernate/Cfg/BindMappingEventArgs.cs

@@ -5,15 +5,22 @@ namespace NHibernate.Cfg
 {
 	public class BindMappingEventArgs: EventArgs
 	{
-		public BindMappingEventArgs(Dialect.Dialect dialect, HbmMapping mapping, string fileName)
+		[Obsolete("Please use constructor without a dialect parameter.", true)]
+		public BindMappingEventArgs(Dialect.Dialect dialect, HbmMapping mapping, string fileName) : this(mapping, fileName)
 		{
 			Dialect = dialect;
+		}
+
+		public BindMappingEventArgs(HbmMapping mapping, string fileName)
+		{
 			Mapping = mapping;
 			FileName = fileName;
 		}
 
-		public Dialect.Dialect Dialect { get; private set; }
-		public HbmMapping Mapping { get; private set; }
-		public string FileName { get; private set; }
+		//Since v5.2
+		[Obsolete("This property will be removed in a future version.", true)]
+		public Dialect.Dialect Dialect { get; }
+		public HbmMapping Mapping { get; }
+		public string FileName { get; }
 	}
 }

src/NHibernate/Cfg/Configuration.cs

@@ -518,12 +518,11 @@ public void AddDeserializedMapping(HbmMapping mappingDocument, string documentFi
 			}
 			try
 			{
-				Dialect.Dialect dialect = Dialect.Dialect.GetDialect(properties);
-				OnBeforeBindMapping(new BindMappingEventArgs(dialect, mappingDocument, documentFileName));
+				OnBeforeBindMapping(new BindMappingEventArgs(mappingDocument, documentFileName));
 				Mappings mappings = CreateMappings();
 
 				new MappingRootBinder(mappings).Bind(mappingDocument);
-				OnAfterBindMapping(new BindMappingEventArgs(dialect, mappingDocument, documentFileName));
+				OnAfterBindMapping(new BindMappingEventArgs(mappingDocument, documentFileName));
 			}
 			catch (Exception e)
 			{