Avoid completing twice the same transaction

fredericDelaporte · hazzik · commit 462c8bd5396b · 2018-06-15T13:30:55.000+12:00
As seen in #1729, some implementation may "complete" many time the same transaction. NHibernate enlistment should detect this and complete a single time.
diff --git a/src/NHibernate/Transaction/AdoNetWithSystemTransactionFactory.cs b/src/NHibernate/Transaction/AdoNetWithSystemTransactionFactory.cs
@@ -411,6 +411,10 @@ protected virtual void ProcessSecondPhase(Enlistment enlistment, bool? success)
 			/// otherwise.</param>
 			protected virtual void CompleteTransaction(bool isCommitted)
 			{
+				// Some implementations (Mono) may "re-complete" the transaction on the cloned transaction disposal:
+				// do an early exit here in such case.
+				if (!IsInActiveTransaction)
+					return;
 				try
 				{
 					// Allow transaction completed actions to run while others stay blocked.

Original file line number	Diff line number	Diff line change
`@@ -411,6 +411,10 @@ protected virtual void ProcessSecondPhase(Enlistment enlistment, bool? success)`
`411`	`411`	`/// otherwise.</param>`
`412`	`412`	`protected virtual void CompleteTransaction(bool isCommitted)`
`413`	`413`	`{`
	`414`	`+ // Some implementations (Mono) may "re-complete" the transaction on the cloned transaction disposal:`
	`415`	`+ // do an early exit here in such case.`
	`416`	`+ if (!IsInActiveTransaction)`
	`417`	`+ return;`
`414`	`418`	`try`
`415`	`419`	`{`
`416`	`420`	`// Allow transaction completed actions to run while others stay blocked.`