fixup! Support evaluation of DateTime.Now on db side

Switch legacy pre-evaluation on by default

Author: fredericDelaporte

doc/reference/modules/configuration.xml

@@ -722,7 +722,7 @@ var session = sessions.OpenSession(conn);
                             <literal>linqtohql.legacy_preevaluation</literal>
                         </entry>
                         <entry>
-                            Whether to use the legacy pre-evaluation or not in Linq queries. Defaults to <literal>false</literal>.
+                            Whether to use the legacy pre-evaluation or not in Linq queries. Defaults to <literal>true</literal>.
                             <para>
                                 <emphasis role="strong">eg.</emphasis>
                                 <literal>true</literal> | <literal>false</literal>
@@ -738,6 +738,9 @@ var session = sessions.OpenSession(conn);
                                 UUIDs for each row instead of an unique one for all rows. (This does not happen if the dialect does
                                 not support the required HQL function.)
                             </para>
+                            <para>
+                                The new pre-evaluation will likely be enabled by default in the next major version (6.0).
+                            </para>
                         </entry>
                     </row>
                     <row>

src/NHibernate.Test/Async/Linq/PreEvaluationTests.cs

@@ -30,8 +30,7 @@ protected override void Configure(Configuration configuration)
 			base.Configure(configuration);
 
 			configuration.SetProperty(Environment.FormatSql, "false");
-			if (LegacyPreEvaluation)
-				configuration.SetProperty(Environment.LinqToHqlLegacyPreEvaluation, "true");
+			configuration.SetProperty(Environment.LinqToHqlLegacyPreEvaluation, LegacyPreEvaluation.ToString());
 		}
 
 		[Test]

src/NHibernate.Test/Linq/PreEvaluationTests.cs

@@ -18,8 +18,7 @@ protected override void Configure(Configuration configuration)
 			base.Configure(configuration);
 
 			configuration.SetProperty(Environment.FormatSql, "false");
-			if (LegacyPreEvaluation)
-				configuration.SetProperty(Environment.LinqToHqlLegacyPreEvaluation, "true");
+			configuration.SetProperty(Environment.LinqToHqlLegacyPreEvaluation, LegacyPreEvaluation.ToString());
 		}
 
 		[Test]

src/NHibernate/Cfg/Environment.cs

@@ -216,7 +216,7 @@ public static string Version
 		public const string LinqToHqlGeneratorsRegistry = "linqtohql.generatorsregistry";
 
 		/// <summary>
-		/// Whether to use the legacy pre-evaluation or not in Linq queries. <c>false</c> by default.
+		/// Whether to use the legacy pre-evaluation or not in Linq queries. <c>true</c> by default.
 		/// </summary>
 		/// <remarks>
 		/// <para>
@@ -230,6 +230,9 @@ public static string Version
 		/// UUIDs for each row instead of an unique one for all rows. (This does not happen if the dialect does
 		/// not support the required HQL function.)
 		/// </para>
+		/// <para>
+		/// The new pre-evaluation will likely be enabled by default in the next major version (6.0).
+		/// </para>
 		/// </remarks>
 		public const string LinqToHqlLegacyPreEvaluation = "linqtohql.legacy_preevaluation";
 

src/NHibernate/Cfg/Settings.cs

@@ -135,7 +135,7 @@ public Settings()
 		public ILinqToHqlGeneratorsRegistry LinqToHqlGeneratorsRegistry { get; internal set; }
 
 		/// <summary>
-		/// Whether to use the legacy pre-evaluation or not in Linq queries. <c>false</c> by default.
+		/// Whether to use the legacy pre-evaluation or not in Linq queries. <c>true</c> by default.
 		/// </summary>
 		/// <remarks>
 		/// <para>

src/NHibernate/Cfg/SettingsFactory.cs

@@ -54,7 +54,12 @@ public Settings BuildSettings(IDictionary<string, string> properties)
 			settings.Dialect = dialect;
 
 			settings.LinqToHqlGeneratorsRegistry = LinqToHqlGeneratorsRegistryFactory.CreateGeneratorsRegistry(properties);
-			settings.LinqToHqlLegacyPreEvaluation = PropertiesHelper.GetBoolean(Environment.LinqToHqlLegacyPreEvaluation, properties);
+			// 6.0 TODO: default to false instead of true, and adjust documentation in xsd, xml comment on Environment
+			// and Setting properties, and doc\reference.
+			settings.LinqToHqlLegacyPreEvaluation = PropertiesHelper.GetBoolean(
+				Environment.LinqToHqlLegacyPreEvaluation,
+				properties,
+				true);
 
 			#region SQL Exception converter
 

src/NHibernate/nhibernate-configuration.xsd

@@ -148,7 +148,7 @@
 										<xs:enumeration value="linqtohql.legacy_preevaluation">
 											<xs:annotation>
 												<xs:documentation>
-													Whether to use the legacy pre-evaluation or not in Linq queries. false by default.
+													Whether to use the legacy pre-evaluation or not in Linq queries. true by default.
 
 													Legacy pre-evaluation is causing special properties or functions like DateTime.Now or Guid.NewGuid()
 													to be always evaluated with the .Net runtime and replaced in the query by parameter values.
@@ -157,6 +157,8 @@
 													side. This allows for example to retrieve the server time instead of the client time, or to generate
 													UUIDs for each row instead of an unique one for all rows. (This does not happen if the dialect does
 													not support the required HQL function.)
+
+													The new pre-evaluation will likely be enabled by default in the next major version (6.0).
 												</xs:documentation>
 											</xs:annotation>
 										</xs:enumeration>