Skip to content

Commit 4d07975

Browse files
committed
override AppliesTo(Dialect) instead of checking the dialect twice
1 parent f5994c3 commit 4d07975

File tree

1 file changed

+6
-6
lines changed
  • src/NHibernate.Test/NHSpecificTest/NH1171

1 file changed

+6
-6
lines changed

src/NHibernate.Test/NHSpecificTest/NH1171/Fixture.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ namespace NHibernate.Test.NHSpecificTest.NH1171
77
[TestFixture]
88
public class Fixture : BugTestCase
99
{
10+
protected override bool AppliesTo(Dialect.Dialect dialect)
11+
{
12+
// Firebird has issues with comments containing apostrophes
13+
return !(dialect is FirebirdDialect);
14+
}
15+
1016
protected override void Configure(NHibernate.Cfg.Configuration configuration)
1117
{
1218
configuration.SetProperty(Environment.FormatSql, "false");
@@ -15,9 +21,6 @@ protected override void Configure(NHibernate.Cfg.Configuration configuration)
1521
[Test]
1622
public void SupportSQLQueryWithComments()
1723
{
18-
if (Dialect is FirebirdDialect)
19-
Assert.Ignore("Firebird has issues with comments containing apostrophes");
20-
2124
string sql =
2225
@"
2326
SELECT id
@@ -38,9 +41,6 @@ ORDER BY Name
3841
[Test]
3942
public void ExecutedContainsComments()
4043
{
41-
if (Dialect is FirebirdDialect)
42-
Assert.Ignore("Firebird has issues with comments containing apostrophes");
43-
4444
string sql =
4545
@"
4646
SELECT id

0 commit comments

Comments
 (0)