Merge pull request #671 from fredericDelaporte/TestWarnings

Purge tests compilation warnings

Author: fredericDelaporte

src/NHibernate.DomainModel/NHibernate.DomainModel.csproj

@@ -12,6 +12,11 @@
     <NoWarn>$(NoWarn);3001;3002;3003;3005</NoWarn>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
+    <TreatSpecificWarningsAsErrors />
+  </PropertyGroup>
+
   <ItemGroup>
     <None Remove="**\*.hbm.xml" />
   </ItemGroup>

src/NHibernate.Test/Generatedkeys/Identity/MyEntityIdentity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Generatedkeys.Identity
 {
 	public class MyEntityIdentity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private int id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 
 		public virtual int Id

src/NHibernate.Test/Generatedkeys/Select/MyEntity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Generatedkeys.Select
 {
 	public class MyEntity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private int id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 		protected MyEntity() {}
 

src/NHibernate.Test/Generatedkeys/Seqidentity/MyEntity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Generatedkeys.Seqidentity
 {
 	public class MyEntity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private int id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 
 		public virtual int Id

src/NHibernate.Test/Hql/Ast/KeyManyToOneEntity.cs

@@ -4,7 +4,10 @@ namespace NHibernate.Test.Hql.Ast
 {
 	public class KeyManyToOneEntity
 	{
+		// Used by reflection
+#pragma warning disable CS0169 // The field is never used
 		private Id id;
+#pragma warning restore CS0169 // The field is never used
 		private string name;
 
 		public virtual string Name

src/NHibernate.Test/Hql/Ast/KeyManyToOneKeyEntity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Hql.Ast
 {
 	public class KeyManyToOneKeyEntity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private long id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 		private int? requestedHash;
 

src/NHibernate.Test/IdGen/Enhanced/Forcedtable/Entity.cs

@@ -3,9 +3,10 @@
 	public class Entity
 	{
 
-#pragma warning disable 0414  // unassigned variable
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private long _id;
-#pragma warning restore 0414
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 
 		public virtual long Id
 		{

src/NHibernate.Test/IdGen/Enhanced/Sequence/Entity.cs

@@ -2,10 +2,10 @@
 {
 	public class Entity
 	{
-
-#pragma warning disable 0414  // unassigned variable
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value 0
 		private long _id;
-#pragma warning restore 0414
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value 0
 
 		public virtual long Id
 		{

src/NHibernate.Test/IdGen/Enhanced/Table/Entity.cs

@@ -2,10 +2,10 @@ namespace NHibernate.Test.IdGen.Enhanced.Table
 {
 	public class Entity
 	{
-
-#pragma warning disable 0414  // unassigned variable
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private long _id;
-#pragma warning restore 0414
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 
 		public virtual long Id
 		{

src/NHibernate.Test/MappingByCode/ConventionModelMapperTests/ComponetsAccessorTests.cs

@@ -10,7 +10,10 @@ public class ComponetsAccessorTests
 		private class MyClass
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private MyCompo compo;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public MyCompo Compo
 			{
 				get { return compo; }

src/NHibernate.Test/MappingByCode/ConventionModelMapperTests/ComponetsParentAccessorTests.cs

@@ -17,7 +17,11 @@ private class MyClass
 
 		private class MyCompo
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private MyClass parent;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
+
 			public MyClass Parent
 			{
 				get { return parent; }
@@ -28,7 +32,10 @@ public MyClass Parent
 
 		private class MyNestedCompo
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private MyCompo owner;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public MyCompo Owner
 			{
 				get { return owner; }

src/NHibernate.Test/MappingByCode/ConventionModelMapperTests/PropertyToFieldAccessorTest.cs

@@ -11,7 +11,10 @@ public class PropertyToFieldAccessorTest
 		private class MyClass
 		{
 			public int Id { get; set; }
+			// Used by reflection
+#pragma warning disable CS0169 // The field is never used
 			private string aField;
+#pragma warning restore CS0169 // The field is never used
 			public int AProp { get; set; }
 
 			private ICollection<int> withDifferentBackField;
@@ -21,7 +24,10 @@ public IEnumerable<int> WithDifferentBackField
 				set { withDifferentBackField = value as ICollection<int>; }
 			}
 
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private string readOnlyWithSameBackField;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public string ReadOnlyWithSameBackField
 			{
 				get { return readOnlyWithSameBackField; }

src/NHibernate.Test/MappingByCode/ConventionModelMapperTests/SafePoidTests.cs

@@ -13,7 +13,10 @@ private class MyClassWithoutPoid
 
 		private class MyClass
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private int _id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public int Id
 			{
 				get { return _id; }

src/NHibernate.Test/MappingByCode/ExplicitMappingTests/IdBagMappingTest.cs

@@ -12,7 +12,10 @@ public class IdBagMappingTest
 		private class Animal
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private ICollection<Animal> children;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public ICollection<Animal> Children
 			{
 				get { return children; }

src/NHibernate.Test/MappingByCode/ExplicitMappingTests/MappingOfPrivateMembersOnRootEntity.cs

@@ -9,9 +9,12 @@ public class MappingOfPrivateMembersOnRootEntity
 	{
 		public class MyClass
 		{
+			// Used by reflection.
+#pragma warning disable CS0169 // The field is never used
 			private int id;
 			private int version;
 			private string something;
+#pragma warning disable CS0169 // The field is never used
 		}
 
 		[Test]

src/NHibernate.Test/MappingByCode/MappersTests/ClassMapperTests/CheckMixingPOIDStrategiesTests.cs

@@ -13,7 +13,10 @@ private class PersonId
 
 		private class Person
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private PersonId id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public PersonId Id
 			{
 				get { return id; }

src/NHibernate.Test/MappingByCode/MappersTests/ClassMapperTests/ComponetAsIdTests.cs

@@ -17,7 +17,10 @@ private class PersonId
 
 		private class Person
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private PersonId id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public PersonId Id
 			{
 				get { return id; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/AnyPropertyOnDynamicCompoTests.cs

@@ -12,7 +12,10 @@ public class AnyPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/BagPropertyOnDynamicCompoTests.cs

@@ -13,7 +13,10 @@ public class BagPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/ComponentPropertyOnDynamicCompoTests.cs

@@ -12,7 +12,10 @@ public class ComponentPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/DynComponentPropertyOnDynamicCompoTests.cs

@@ -12,7 +12,10 @@ public class DynComponentPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/IdBagPropertyOnDynamicCompoTests.cs

@@ -13,7 +13,10 @@ public class IdBagPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/ListPropertyOnDynamicCompoTests.cs

@@ -13,7 +13,10 @@ public class ListPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/ManyToOnePropertyOnDynamicCompoTests.cs

@@ -12,7 +12,10 @@ public class ManyToOnePropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/MapPropertyOnDynamicCompoTests.cs

@@ -13,7 +13,10 @@ public class MapPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/OneToOnePropertyOnDynamicCompoTests.cs

@@ -12,7 +12,10 @@ public class OneToOnePropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/SetPropertyOnDynamicCompoTests.cs

@@ -13,7 +13,10 @@ public class SetPropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/DynamicComponentMapperTests/SimplePropertyOnDynamicCompoTests.cs

@@ -12,7 +12,10 @@ public class SimplePropertyOnDynamicCompoTests
 		private class Person
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private IDictionary info;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IDictionary Info
 			{
 				get { return info; }

src/NHibernate.Test/MappingByCode/MappersTests/IdMapperTest.cs

@@ -116,7 +116,10 @@ public void CanSetGeneratorEnhancedTable()
 		}
 		private class BaseEntity
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private int id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 
 			public int Id
 			{

src/NHibernate.Test/MappingByCode/MappersTests/PropertyMapperTest.cs

@@ -324,7 +324,7 @@ public class MyType : IUserType
 	{
 		#region Implementation of IUserType
 
-		public bool Equals(object x, object y)
+		public new bool Equals(object x, object y)
 		{
 			throw new NotImplementedException();
 		}
@@ -394,7 +394,7 @@ public void SetPropertyValue(object component, int property, object value)
 			throw new NotImplementedException();
 		}
 
-		public bool Equals(object x, object y)
+		public new bool Equals(object x, object y)
 		{
 			throw new NotImplementedException();
 		}

src/NHibernate.Test/MappingByCode/MixAutomapping/ArrayCollectionTests.cs

@@ -9,8 +9,11 @@ public class ArrayCollectionTests
 	{
 		private class Entity
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private ICollection<string> others;
 			private string[] emails;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public string[] NickNames { get; set; }
 			public byte[] Photo { get; set; }
 

src/NHibernate.Test/MappingByCode/MixAutomapping/BagCollectionTests.cs

@@ -12,7 +12,10 @@ public class BagCollectionTests
 		// match any IEnumerable
 		private class Entity
 		{
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private ICollection<string> emails;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public IEnumerable<string> NickNames { get; set; }
 			public byte[] Bytes { get; set; }
 			public object Emails