Cease throwing bare Exception (#1498)

fredericDelaporte · hazzik · commit 699db48f799a · 2017-12-24T00:40:45.000+13:00
diff --git a/src/NHibernate.DomainModel/Foo.cs b/src/NHibernate.DomainModel/Foo.cs
@@ -322,7 +322,7 @@ public FooComponent Component
 		public FooComponent NullComponent
 		{
 			get { return null; }
-			set { if (value != null) throw new Exception("Null component"); }
+			set { if (value != null) throw new ArgumentException("Null component"); }
 		}
 
 		#endregion
@@ -432,4 +432,4 @@ public bool EqualsFoo(Foo other)
 
 		private static int count = 0;
 	}
-}
+}
diff --git a/src/NHibernate.DomainModel/FooComponent.cs b/src/NHibernate.DomainModel/FooComponent.cs
@@ -110,7 +110,7 @@ private String NullString
 			set
 			{
 				if (value != null)
-					throw new Exception("null component property");
+					throw new ArgumentException("null component property");
 			}
 		}
 
@@ -179,4 +179,4 @@ public override string ToString()
 
 		#endregion
 	}
-}
+}
diff --git a/src/NHibernate.Test/Async/NHSpecificTest/NH2583/Domain.cs b/src/NHibernate.Test/Async/NHSpecificTest/NH2583/Domain.cs
@@ -78,7 +78,7 @@ public partial class MyBO
                     set(await (bo.GetOrCreateBO1Async(s, cancellationToken)), 1);
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
 
@@ -114,7 +114,7 @@ public partial class MyBO
                     set(await (bo.GetOrCreateBO2Async(s, cancellationToken)), 1);
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
 
@@ -153,7 +153,7 @@ public partial class MyBO
                     set(await ((await (bo.GetOrCreateBO1Async(s, cancellationToken))).GetOrCreateBO2Async(s, cancellationToken)), 1);
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
 
@@ -187,7 +187,7 @@ public partial class MyBO
                     (await ((await (bo.GetOrCreateBO1Async(s, cancellationToken))).GetOrCreateBO3Async(s, cancellationToken))).L1 = 1;
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
     }
diff --git a/src/NHibernate.Test/Async/QueryTest/DetachedQueryFixture.cs b/src/NHibernate.Test/Async/QueryTest/DetachedQueryFixture.cs
@@ -260,7 +260,7 @@ public Dictionary<string, TypedValue> NamedListParams
 
 			public override IQuery GetExecutableQuery(ISession session)
 			{
-				throw new Exception("The method or operation is not implemented.");
+				throw new NotImplementedException("The method or operation is not implemented.");
 			}
 
 			public new void CopyTo(IDetachedQuery destination)
diff --git a/src/NHibernate.Test/Criteria/Lambda/QueryOverFixture.cs b/src/NHibernate.Test/Criteria/Lambda/QueryOverFixture.cs
@@ -47,7 +47,7 @@ public void SimpleCriterion_NoAlias()
 		public static int CompareString(string left, string right, bool textCompare)
 		{
 			// could consider calling Microsoft.VisualBasic.CompilerServices.Operators.CompareString
-			throw new Exception("This is just here to allow us to simulate the VB.Net LINQ expression tree");
+			throw new InvalidOperationException("This is just here to allow us to simulate the VB.Net LINQ expression tree");
 		}
 
 		[Test]
diff --git a/src/NHibernate.Test/DynamicProxyTests/PeVerifier.cs b/src/NHibernate.Test/DynamicProxyTests/PeVerifier.cs
@@ -26,7 +26,7 @@ public PeVerifier(string assemblyFileName)
 			while (!Directory.Exists(Path.Combine(dir, "Tools", "PEVerify")))
 			{
 				if (Directory.GetParent(dir) == null)
-					throw new Exception(string.Format("Could not find Tools/PEVerify directory in ancestor of {0}", _assemlyLocation));
+					throw new DirectoryNotFoundException(string.Format("Could not find Tools/PEVerify directory in ancestor of {0}", _assemlyLocation));
 
 				dir = Directory.GetParent(dir).FullName;
 			}
@@ -38,7 +38,7 @@ public PeVerifier(string assemblyFileName)
 			_peVerifyPath = Path.Combine(dir, "Tools", "PEVerify", versionFolder, "PEVerify.exe");
 
 			if (!File.Exists(_peVerifyPath))
-				throw new Exception(string.Format("Could not find PEVerify.exe at {0}", _peVerifyPath));
+				throw new FileNotFoundException(string.Format("Could not find PEVerify.exe at {0}", _peVerifyPath));
 		}
 
 		public void AssertIsValid()
diff --git a/src/NHibernate.Test/LogSpy.cs b/src/NHibernate.Test/LogSpy.cs
@@ -19,7 +19,7 @@ public LogSpy(ILog log, Level level)
 			logger = log.Logger as Logger;
 			if (logger == null)
 			{
-				throw new Exception("Unable to get the logger");
+				throw new InvalidOperationException("Unable to get the logger");
 			}
 
 			// Change the log level to DEBUG and temporarily save the previous log level
diff --git a/src/NHibernate.Test/NHSpecificTest/NH2583/Domain.cs b/src/NHibernate.Test/NHSpecificTest/NH2583/Domain.cs
@@ -153,7 +153,7 @@ public static void SetK1(MyBO bo, ISession s, TK value)
                     bo.K1 = 1;
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
 
@@ -184,7 +184,7 @@ private static void SetBO1_I(MyBO bo, ISession s, TBO1_I value, Action<MyRef1, i
                     set(bo.GetOrCreateBO1(s), 1);
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
 
@@ -220,7 +220,7 @@ private static void SetBO2_J(MyBO bo, ISession s, TBO2_J value, Action<MyRef2, i
                     set(bo.GetOrCreateBO2(s), 1);
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
 
@@ -259,7 +259,7 @@ private static void SetBO1_BO2_J(MyBO bo, ISession s, TBO1_BO2_J value, Action<M
                     set(bo.GetOrCreateBO1(s).GetOrCreateBO2(s), 1);
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
 
@@ -293,7 +293,7 @@ public static void SetBO1_BO3_L1(MyBO bo, ISession s, TBO1_BO3_L value)
                     bo.GetOrCreateBO1(s).GetOrCreateBO3(s).L1 = 1;
                     break;
                 default:
-                    throw new Exception("Value " + value + " not handled in code");
+                    throw new NotImplementedException("Value " + value + " not handled in code");
             }
         }
     }
diff --git a/src/NHibernate.Test/QueryTest/DetachedQueryFixture.cs b/src/NHibernate.Test/QueryTest/DetachedQueryFixture.cs
@@ -544,7 +544,7 @@ public Dictionary<string, TypedValue> NamedListParams
 
 			public override IQuery GetExecutableQuery(ISession session)
 			{
-				throw new Exception("The method or operation is not implemented.");
+				throw new NotImplementedException("The method or operation is not implemented.");
 			}
 
 			public new void CopyTo(IDetachedQuery destination)
diff --git a/src/NHibernate/Criterion/Projections.cs b/src/NHibernate/Criterion/Projections.cs
@@ -452,7 +452,7 @@ public static AggregateProjection Sum(Expression<Func<object>> expression)
 		/// </summary>
 		public static string Concat(params string[] strings)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessConcat(MethodCallExpression methodCallExpression)
diff --git a/src/NHibernate/Criterion/ProjectionsExtensions.cs b/src/NHibernate/Criterion/ProjectionsExtensions.cs
@@ -70,7 +70,7 @@ internal static IProjection ProcessDate(System.Linq.Expressions.Expression expre
 		/// </summary>
 		public static double Sqrt(this double numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		/// <summary>
@@ -79,7 +79,7 @@ public static double Sqrt(this double numericProperty)
 		/// </summary>
 		public static double Sqrt(this int numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		/// <summary>
@@ -88,7 +88,7 @@ public static double Sqrt(this int numericProperty)
 		/// </summary>
 		public static double Sqrt(this long numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		/// <summary>
@@ -97,7 +97,7 @@ public static double Sqrt(this long numericProperty)
 		/// </summary>
 		public static double Sqrt(this decimal numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		/// <summary>
@@ -106,7 +106,7 @@ public static double Sqrt(this decimal numericProperty)
 		/// </summary>
 		public static double Sqrt(this byte numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessSqrt(MethodCallExpression methodCallExpression)
@@ -121,7 +121,7 @@ internal static IProjection ProcessSqrt(MethodCallExpression methodCallExpressio
 		/// </summary>
 		public static string Lower(this string stringProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessLower(MethodCallExpression methodCallExpression)
@@ -136,7 +136,7 @@ internal static IProjection ProcessLower(MethodCallExpression methodCallExpressi
 		/// </summary>
 		public static string Upper(this string stringProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessUpper(MethodCallExpression methodCallExpression)
@@ -151,7 +151,7 @@ internal static IProjection ProcessUpper(MethodCallExpression methodCallExpressi
 		/// </summary>
 		public static int Abs(this int numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessIntAbs(MethodCallExpression methodCallExpression)
@@ -166,7 +166,7 @@ internal static IProjection ProcessIntAbs(MethodCallExpression methodCallExpress
 		/// </summary>
 		public static Int64 Abs(this Int64 numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessInt64Abs(MethodCallExpression methodCallExpression)
@@ -195,7 +195,7 @@ internal static IProjection ProcessRound(MethodCallExpression methodCallExpressi
 		/// </summary>
 		public static double Abs(this double numericProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessDoubleAbs(MethodCallExpression methodCallExpression)
@@ -210,7 +210,7 @@ internal static IProjection ProcessDoubleAbs(MethodCallExpression methodCallExpr
 		/// </summary>
 		public static string TrimStr(this string stringProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessTrimStr(MethodCallExpression methodCallExpression)
@@ -225,7 +225,7 @@ internal static IProjection ProcessTrimStr(MethodCallExpression methodCallExpres
 		/// </summary>
 		public static int StrLength(this string stringProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessStrLength(MethodCallExpression methodCallExpression)
@@ -240,7 +240,7 @@ internal static IProjection ProcessStrLength(MethodCallExpression methodCallExpr
 		/// </summary>
 		public static int BitLength(this string stringProperty)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessBitLength(MethodCallExpression methodCallExpression)
@@ -255,7 +255,7 @@ internal static IProjection ProcessBitLength(MethodCallExpression methodCallExpr
 		/// </summary>
 		public static string Substr(this string stringProperty, int startIndex, int length)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessSubstr(MethodCallExpression methodCallExpression)
@@ -272,7 +272,7 @@ internal static IProjection ProcessSubstr(MethodCallExpression methodCallExpress
 		/// </summary>
 		public static int CharIndex(this string stringProperty, string theChar, int startLocation)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessCharIndex(MethodCallExpression methodCallExpression)
@@ -289,7 +289,7 @@ internal static IProjection ProcessCharIndex(MethodCallExpression methodCallExpr
 		/// </summary>
 		public static T Coalesce<T>(this T objectProperty, T replaceValueIfIsNull)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		/// <summary>
@@ -298,7 +298,7 @@ public static T Coalesce<T>(this T objectProperty, T replaceValueIfIsNull)
 		/// </summary>
 		public static T? Coalesce<T>(this T? objectProperty, T replaceValueIfIsNull) where T : struct
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessCoalesce(MethodCallExpression methodCallExpression)
@@ -314,7 +314,7 @@ internal static IProjection ProcessCoalesce(MethodCallExpression methodCallExpre
 		/// </summary>
 		public static int Mod(this int numericProperty, int divisor)
 		{
-			throw new Exception("Not to be used directly - use inside QueryOver expression");
+			throw QueryOver.GetDirectUsageException();
 		}
 
 		internal static IProjection ProcessMod(MethodCallExpression methodCallExpression)
diff --git a/src/NHibernate/Criterion/QueryOver.cs b/src/NHibernate/Criterion/QueryOver.cs
@@ -56,6 +56,10 @@ public DetachedCriteria DetachedCriteria
 			get { return new DetachedCriteria(impl, impl); }
 		}
 
+		internal static Exception GetDirectUsageException()
+		{
+			return new InvalidOperationException("Not to be used directly - use inside QueryOver expression");
+		}
 	}
 
 	[Serializable]
diff --git a/src/NHibernate/Criterion/RestrictionsExtensions.cs b/src/NHibernate/Criterion/RestrictionsExtensions.cs
diff --git a/src/NHibernate/Dialect/Schema/SchemaHelper.cs b/src/NHibernate/Dialect/Schema/SchemaHelper.cs
diff --git a/src/NHibernate/Impl/ExpressionProcessor.cs b/src/NHibernate/Impl/ExpressionProcessor.cs
diff --git a/src/NHibernate/Loader/TopologicalSorter.cs b/src/NHibernate/Loader/TopologicalSorter.cs
diff --git a/src/NHibernate/Mapping/ByCode/TypeExtensions.cs b/src/NHibernate/Mapping/ByCode/TypeExtensions.cs

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,7 @@ public FooComponent Component`
`322`	`322`	`public FooComponent NullComponent`
`323`	`323`	`{`
`324`	`324`	`get { return null; }`
`325`		`- set { if (value != null) throw new Exception("Null component"); }`
	`325`	`+ set { if (value != null) throw new ArgumentException("Null component"); }`
`326`	`326`	`}`
`327`	`327`
`328`	`328`	`#endregion`
`@@ -432,4 +432,4 @@ public bool EqualsFoo(Foo other)`
`432`	`432`
`433`	`433`	`private static int count = 0;`
`434`	`434`	`}`
`435`		`-}`
	`435`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ private String NullString`
`110`	`110`	`set`
`111`	`111`	`{`
`112`	`112`	`if (value != null)`
`113`		`- throw new Exception("null component property");`
	`113`	`+ throw new ArgumentException("null component property");`
`114`	`114`	`}`
`115`	`115`	`}`
`116`	`116`
`@@ -179,4 +179,4 @@ public override string ToString()`
`179`	`179`
`180`	`180`	`#endregion`
`181`	`181`	`}`
`182`		`-}`
	`182`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public partial class MyBO`
`78`	`78`	`set(await (bo.GetOrCreateBO1Async(s, cancellationToken)), 1);`
`79`	`79`	`break;`
`80`	`80`	`default:`
`81`		`- throw new Exception("Value " + value + " not handled in code");`
	`81`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`
`@@ -114,7 +114,7 @@ public partial class MyBO`
`114`	`114`	`set(await (bo.GetOrCreateBO2Async(s, cancellationToken)), 1);`
`115`	`115`	`break;`
`116`	`116`	`default:`
`117`		`- throw new Exception("Value " + value + " not handled in code");`
	`117`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`118`	`118`	`}`
`119`	`119`	`}`
`120`	`120`
`@@ -153,7 +153,7 @@ public partial class MyBO`
`153`	`153`	`set(await ((await (bo.GetOrCreateBO1Async(s, cancellationToken))).GetOrCreateBO2Async(s, cancellationToken)), 1);`
`154`	`154`	`break;`
`155`	`155`	`default:`
`156`		`- throw new Exception("Value " + value + " not handled in code");`
	`156`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`@@ -187,7 +187,7 @@ public partial class MyBO`
`187`	`187`	`(await ((await (bo.GetOrCreateBO1Async(s, cancellationToken))).GetOrCreateBO3Async(s, cancellationToken))).L1 = 1;`
`188`	`188`	`break;`
`189`	`189`	`default:`
`190`		`- throw new Exception("Value " + value + " not handled in code");`
	`190`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`191`	`191`	`}`
`192`	`192`	`}`
`193`	`193`	`}`
Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ public Dictionary<string, TypedValue> NamedListParams`
`260`	`260`
`261`	`261`	`public override IQuery GetExecutableQuery(ISession session)`
`262`	`262`	`{`
`263`		`- throw new Exception("The method or operation is not implemented.");`
	`263`	`+ throw new NotImplementedException("The method or operation is not implemented.");`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`public new void CopyTo(IDetachedQuery destination)`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public void SimpleCriterion_NoAlias()`
`47`	`47`	`public static int CompareString(string left, string right, bool textCompare)`
`48`	`48`	`{`
`49`	`49`	`// could consider calling Microsoft.VisualBasic.CompilerServices.Operators.CompareString`
`50`		`- throw new Exception("This is just here to allow us to simulate the VB.Net LINQ expression tree");`
	`50`	`+ throw new InvalidOperationException("This is just here to allow us to simulate the VB.Net LINQ expression tree");`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`[Test]`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public PeVerifier(string assemblyFileName)`
`26`	`26`	`while (!Directory.Exists(Path.Combine(dir, "Tools", "PEVerify")))`
`27`	`27`	`{`
`28`	`28`	`if (Directory.GetParent(dir) == null)`
`29`		`- throw new Exception(string.Format("Could not find Tools/PEVerify directory in ancestor of {0}", _assemlyLocation));`
	`29`	`+ throw new DirectoryNotFoundException(string.Format("Could not find Tools/PEVerify directory in ancestor of {0}", _assemlyLocation));`
`30`	`30`
`31`	`31`	`dir = Directory.GetParent(dir).FullName;`
`32`	`32`	`}`
`@@ -38,7 +38,7 @@ public PeVerifier(string assemblyFileName)`
`38`	`38`	`_peVerifyPath = Path.Combine(dir, "Tools", "PEVerify", versionFolder, "PEVerify.exe");`
`39`	`39`
`40`	`40`	`if (!File.Exists(_peVerifyPath))`
`41`		`- throw new Exception(string.Format("Could not find PEVerify.exe at {0}", _peVerifyPath));`
	`41`	`+ throw new FileNotFoundException(string.Format("Could not find PEVerify.exe at {0}", _peVerifyPath));`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`public void AssertIsValid()`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public LogSpy(ILog log, Level level)`
`19`	`19`	`logger = log.Logger as Logger;`
`20`	`20`	`if (logger == null)`
`21`	`21`	`{`
`22`		`- throw new Exception("Unable to get the logger");`
	`22`	`+ throw new InvalidOperationException("Unable to get the logger");`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`// Change the log level to DEBUG and temporarily save the previous log level`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public static void SetK1(MyBO bo, ISession s, TK value)`
`153`	`153`	`bo.K1 = 1;`
`154`	`154`	`break;`
`155`	`155`	`default:`
`156`		`- throw new Exception("Value " + value + " not handled in code");`
	`156`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`@@ -184,7 +184,7 @@ private static void SetBO1_I(MyBO bo, ISession s, TBO1_I value, Action<MyRef1, i`
`184`	`184`	`set(bo.GetOrCreateBO1(s), 1);`
`185`	`185`	`break;`
`186`	`186`	`default:`
`187`		`- throw new Exception("Value " + value + " not handled in code");`
	`187`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`188`	`188`	`}`
`189`	`189`	`}`
`190`	`190`
`@@ -220,7 +220,7 @@ private static void SetBO2_J(MyBO bo, ISession s, TBO2_J value, Action<MyRef2, i`
`220`	`220`	`set(bo.GetOrCreateBO2(s), 1);`
`221`	`221`	`break;`
`222`	`222`	`default:`
`223`		`- throw new Exception("Value " + value + " not handled in code");`
	`223`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`224`	`224`	`}`
`225`	`225`	`}`
`226`	`226`
`@@ -259,7 +259,7 @@ private static void SetBO1_BO2_J(MyBO bo, ISession s, TBO1_BO2_J value, Action<M`
`259`	`259`	`set(bo.GetOrCreateBO1(s).GetOrCreateBO2(s), 1);`
`260`	`260`	`break;`
`261`	`261`	`default:`
`262`		`- throw new Exception("Value " + value + " not handled in code");`
	`262`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`263`	`263`	`}`
`264`	`264`	`}`
`265`	`265`
`@@ -293,7 +293,7 @@ public static void SetBO1_BO3_L1(MyBO bo, ISession s, TBO1_BO3_L value)`
`293`	`293`	`bo.GetOrCreateBO1(s).GetOrCreateBO3(s).L1 = 1;`
`294`	`294`	`break;`
`295`	`295`	`default:`
`296`		`- throw new Exception("Value " + value + " not handled in code");`
	`296`	`+ throw new NotImplementedException("Value " + value + " not handled in code");`
`297`	`297`	`}`
`298`	`298`	`}`
`299`	`299`	`}`
Original file line number	Diff line number	Diff line change
`@@ -544,7 +544,7 @@ public Dictionary<string, TypedValue> NamedListParams`
`544`	`544`
`545`	`545`	`public override IQuery GetExecutableQuery(ISession session)`
`546`	`546`	`{`
`547`		`- throw new Exception("The method or operation is not implemented.");`
	`547`	`+ throw new NotImplementedException("The method or operation is not implemented.");`
`548`	`548`	`}`
`549`	`549`
`550`	`550`	`public new void CopyTo(IDetachedQuery destination)`
Original file line number	Diff line number	Diff line change
`@@ -452,7 +452,7 @@ public static AggregateProjection Sum(Expression<Func<object>> expression)`
`452`	`452`	`/// </summary>`
`453`	`453`	`public static string Concat(params string[] strings)`
`454`	`454`	`{`
`455`		`- throw new Exception("Not to be used directly - use inside QueryOver expression");`
	`455`	`+ throw QueryOver.GetDirectUsageException();`
`456`	`456`	`}`
`457`	`457`
`458`	`458`	`internal static IProjection ProcessConcat(MethodCallExpression methodCallExpression)`