Add test case from NH-1863. Already working since at least 3.3.3.GA.

Author: oskarb

src/NHibernate.Test/NHSpecificTest/NH1863/Domain.cs

@@ -0,0 +1,27 @@
+using Iesi.Collections.Generic;
+
+namespace NHibernate.Test.NHSpecificTest.NH1863
+{
+	public class Customer
+	{
+		private ISet<Category> _categories = new HashedSet<Category>();
+
+		public virtual int Id { get; set; }
+
+		public virtual string Name { get; set; }
+
+		public virtual ISet<Category> Categories
+		{
+			get { return _categories; }
+			set { _categories = value; }
+		}
+	}
+
+	public class Category
+	{
+		public virtual int Id { get; set; }
+
+		public virtual bool IsActive { get; set; }
+	}
+
+}

src/NHibernate.Test/NHSpecificTest/NH1863/Fixture.cs

@@ -0,0 +1,109 @@
+using System.Collections.Generic;
+using NHibernate.Criterion;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.NH1863
+{
+	[TestFixture]
+	public class Fixture : BugTestCase
+	{
+		protected override void OnSetUp()
+		{
+			using (ISession s = OpenSession())
+			{
+				using (ITransaction tx = s.BeginTransaction())
+				{
+					var category = new Category {IsActive = true};
+					s.Save(category);
+
+					var customerWithCategory = new Customer {Name = "HasCategory"};
+					customerWithCategory.Categories.Add(category);
+					s.Save(customerWithCategory);
+
+					var customerWithNoCategory = new Customer {Name = "HasNoCategory"};
+					s.Save(customerWithNoCategory);
+
+					tx.Commit();
+				}
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (ISession s = OpenSession())
+			{
+				using (ITransaction tx = s.BeginTransaction())
+				{
+					s.Delete("from Customer");
+					s.Delete("from Category");
+					tx.Commit();
+				}
+			}
+		}
+
+		[Test]
+		public void CanGetCustomerWithCategoryWhenFilterIsEnabled()
+		{
+			using (ISession session = OpenSession())
+			{
+				IFilter filter = session.EnableFilter("onlyActive");
+				filter.SetParameter("activeFlag", 1);
+
+				ICriteria hasCategoryCriteria = session.CreateCriteria(typeof (Customer));
+				hasCategoryCriteria.Add(Restrictions.Eq("Name", "HasCategory"));
+				IList<Customer> hasCategoryResult = hasCategoryCriteria.List<Customer>();
+
+				Assert.That(hasCategoryResult.Count, Is.EqualTo(1));
+			}
+
+		}
+
+		[Test]
+		public void CanGetCustomerWithCategoryWhenFilterIsDisabled()
+		{
+			using (ISession session = OpenSession())
+			{
+				session.DisableFilter("onlyActive");
+
+				ICriteria hasCategoryCriteria = session.CreateCriteria(typeof (Customer));
+				hasCategoryCriteria.Add(Restrictions.Eq("Name", "HasCategory"));
+				IList<Customer> hasCategoryResult = hasCategoryCriteria.List<Customer>();
+
+				Assert.That(hasCategoryResult.Count, Is.EqualTo(1));
+			}
+		}
+
+		[Test]
+		public void CanGetCustomerWithNoCategoryWhenFilterIsEnabled()
+		{
+			using (ISession session = OpenSession())
+			{
+				IFilter filter = session.EnableFilter("onlyActive");
+				filter.SetParameter("activeFlag", 1);
+
+				ICriteria hasNoCategoryCriteria = session.CreateCriteria(typeof (Customer));
+				hasNoCategoryCriteria.Add(Restrictions.Eq("Name", "HasNoCategory"));
+				IList<Customer> hasNoCategoryResult = hasNoCategoryCriteria.List<Customer>();
+
+				Assert.That(hasNoCategoryResult.Count, Is.EqualTo(1));
+			}
+
+		}
+
+		[Test]
+		public void CanGetCustomerWithNoCategoryWhenFilterIsDisabled()
+		{
+			using (ISession session = OpenSession())
+			{
+				session.DisableFilter("onlyActive");
+
+				ICriteria hasNoCategoryCriteria = session.CreateCriteria(typeof (Customer));
+				hasNoCategoryCriteria.Add(Restrictions.Eq("Name", "HasNoCategory"));
+				IList<Customer> hasNoCategoryResult = hasNoCategoryCriteria.List<Customer>();
+
+				Assert.That(hasNoCategoryResult.Count, Is.EqualTo(1));
+			}
+
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH1863/Mappings.hbm.xml

@@ -0,0 +1,31 @@
+<?xml version="1.0"?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.NH1863">
+
+    <class name="Customer" table="Customer">
+        <id name="Id" column="Id">
+            <generator class="native" />
+        </id>
+        <property name="Name" not-null="true" />
+
+        <set name='Categories' lazy='false' fetch='join'>
+            <key column='Category_Id' />
+            <one-to-many class='Category' />
+            <filter name='onlyActive' condition=':activeFlag = IsActive' />
+        </set>
+
+    </class>
+
+    <class name="Category" table="Category">
+        <id name="Id" column="Id">
+            <generator class="native" />
+        </id>
+        <property name="IsActive" not-null="true" />
+
+        <filter name="onlyActive" condition=":activeFlag = IsActive" />
+    </class>
+
+    <filter-def name="onlyActive">
+        <filter-param name="activeFlag" type="int"/>
+    </filter-def>
+
+</hibernate-mapping>

src/NHibernate.Test/NHibernate.Test.csproj

@@ -670,6 +670,8 @@
     <Compile Include="NHSpecificTest\BagWithLazyExtraAndFilter\Domain.cs" />
     <Compile Include="NHSpecificTest\BagWithLazyExtraAndFilter\Fixture.cs" />
     <Compile Include="Component\Basic\ComponentWithUniqueConstraintTests.cs" />
+    <Compile Include="NHSpecificTest\NH1863\Domain.cs" />
+    <Compile Include="NHSpecificTest\NH1863\Fixture.cs" />
     <Compile Include="MappingByCode\ExpliticMappingTests\ClassWithoutNamespaceTests.cs" />
     <Compile Include="NHSpecificTest\NH1882\Author.cs" />
     <Compile Include="NHSpecificTest\NH1882\Book.cs" />
@@ -2912,6 +2914,7 @@
     <EmbeddedResource Include="NHSpecificTest\NH1291AnonExample\Mappings.hbm.xml" />
   </ItemGroup>
   <ItemGroup>
+    <EmbeddedResource Include="NHSpecificTest\NH1863\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3614\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3505\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3428\Mappings.hbm.xml" />