Replace CacheEntry constructor with factory method

Author: hazzik

src/NHibernate/Action/EntityInsertAction.cs

@@ -81,7 +81,7 @@ public override void Execute()
 
 			if (IsCachePutEnabled(persister))
 			{
-				CacheEntry ce = new CacheEntry(state, persister, persister.HasUninitializedLazyProperties(instance), version, session, instance);
+				CacheEntry ce = CacheEntry.Create(state, persister, persister.HasUninitializedLazyProperties(instance), version, session, instance);
 				cacheEntry = persister.CacheEntryStructure.Structure(ce);
 
 				CacheKey ck = Session.GenerateCacheKey(id, persister.IdentifierType, persister.RootEntityName);

src/NHibernate/Action/EntityUpdateAction.cs

@@ -114,7 +114,7 @@ public override void Execute()
 				}
 				else
 				{
-					CacheEntry ce = new CacheEntry(state, persister, persister.HasUninitializedLazyProperties(instance), nextVersion, Session, instance);
+					CacheEntry ce = CacheEntry.Create(state, persister, persister.HasUninitializedLazyProperties(instance), nextVersion, Session, instance);
 					cacheEntry = persister.CacheEntryStructure.Structure(ce);
 
 					bool put = persister.Cache.Update(ck, cacheEntry, nextVersion, previousVersion);

src/NHibernate/Async/Action/EntityInsertAction.cs

@@ -53,7 +53,7 @@ public override async Task ExecuteAsync()
 			ISessionFactoryImplementor factory = Session.Factory;
 			if (IsCachePutEnabled(persister))
 			{
-				CacheEntry ce = new CacheEntry(state, persister, persister.HasUninitializedLazyProperties(instance), version, session, instance);
+				CacheEntry ce = CacheEntry.Create(state, persister, persister.HasUninitializedLazyProperties(instance), version, session, instance);
 				cacheEntry = persister.CacheEntryStructure.Structure(ce);
 				CacheKey ck = Session.GenerateCacheKey(id, persister.IdentifierType, persister.RootEntityName);
 				bool put = persister.Cache.Insert(ck, cacheEntry, version);

src/NHibernate/Async/Action/EntityUpdateAction.cs

@@ -85,7 +85,7 @@ public override async Task ExecuteAsync()
 				}
 				else
 				{
-					CacheEntry ce = new CacheEntry(state, persister, persister.HasUninitializedLazyProperties(instance), nextVersion, Session, instance);
+					CacheEntry ce = CacheEntry.Create(state, persister, persister.HasUninitializedLazyProperties(instance), nextVersion, Session, instance);
 					cacheEntry = persister.CacheEntryStructure.Structure(ce);
 					bool put = persister.Cache.Update(ck, cacheEntry, nextVersion, previousVersion);
 					if (put && factory.Statistics.IsStatisticsEnabled)

src/NHibernate/Async/Engine/TwoPhaseLoad.cs

@@ -74,7 +74,7 @@ public static async Task InitializeEntityAsync(object entity, bool readOnly, ISe
 				if (log.IsDebugEnabled)
 					log.Debug("adding entity to second-level cache: " + MessageHelper.InfoString(persister, id, session.Factory));
 				object version = Versioning.GetVersion(hydratedState, persister);
-				CacheEntry entry = new CacheEntry(hydratedState, persister, entityEntry.LoadedWithLazyPropertiesUnfetched, version, session, entity);
+				CacheEntry entry = CacheEntry.Create(hydratedState, persister, entityEntry.LoadedWithLazyPropertiesUnfetched, version, session, entity);
 				CacheKey cacheKey = session.GenerateCacheKey(id, persister.IdentifierType, persister.RootEntityName);
 				bool put = persister.Cache.Put(cacheKey, persister.CacheEntryStructure.Structure(entry), session.Timestamp, version, persister.IsVersioned ? persister.VersionType.Comparator : null, UseMinimalPuts(session, entityEntry));
 				if (put && factory.Statistics.IsStatisticsEnabled)

src/NHibernate/Cache/Entry/CacheEntry.cs

@@ -17,14 +17,13 @@ public sealed partial class CacheEntry
 		private readonly bool lazyPropertiesAreUnfetched;
 		private readonly object version;
 
-
-		public CacheEntry(object[] state, IEntityPersister persister, bool unfetched, object version, ISessionImplementor session, object owner)
+		public static CacheEntry Create(object[] state, IEntityPersister persister, bool unfetched, object version, ISessionImplementor session, object owner)
 		{
 			//disassembled state gets put in a new array (we write to cache by value!)
-			disassembledState = TypeHelper.Disassemble(state, persister.PropertyTypes, null, session, owner);
-			subclass = persister.EntityName;
-			lazyPropertiesAreUnfetched = unfetched || !persister.IsLazyPropertiesCacheable;
-			this.version = version;
+			var disassembledState = TypeHelper.Disassemble(state, persister.PropertyTypes, null, session, owner);
+			var subclass = persister.EntityName;
+			var lazyPropertiesAreUnfetched = unfetched || !persister.IsLazyPropertiesCacheable;
+			return new CacheEntry(disassembledState, subclass, lazyPropertiesAreUnfetched, version);
 		}
 
 		internal CacheEntry(object[] state, string subclass, bool unfetched, object version)

src/NHibernate/Engine/TwoPhaseLoad.cs

@@ -105,7 +105,7 @@ public static void InitializeEntity(object entity, bool readOnly, ISessionImplem
 
 				object version = Versioning.GetVersion(hydratedState, persister);
 				CacheEntry entry =
-					new CacheEntry(hydratedState, persister, entityEntry.LoadedWithLazyPropertiesUnfetched, version, session, entity);
+					CacheEntry.Create(hydratedState, persister, entityEntry.LoadedWithLazyPropertiesUnfetched, version, session, entity);
 				CacheKey cacheKey = session.GenerateCacheKey(id, persister.IdentifierType, persister.RootEntityName);
 				bool put =
 					persister.Cache.Put(cacheKey, persister.CacheEntryStructure.Structure(entry), session.Timestamp, version,