Avoid Iesi-specific collection methods.

Author: oskarb

src/NHibernate.Test/NHSpecificTest/NH1028/Fixture.cs

@@ -51,7 +51,7 @@ public void CanLoadCollectionUsingLeftOuterJoin()
 					Assert.AreEqual (shipName, loadedShip.Name);	
 				}
 
-				Assert.IsTrue (loadedItem.Containers.IsEmpty);
+				Assert.That(loadedItem.Containers, Is.Empty);
 			}
 			using (ISession s = OpenSession())
 			{

src/NHibernate.Test/NHSpecificTest/NH1810/Children.cs

@@ -53,10 +53,6 @@ public Children(ICollection<Child> initialValues) : base(initialValues)
 			behaviour = new ChildrenBehaviour(this);
 		}
 
-		public Children(ICollection initialValues) : base(initialValues)
-		{
-			behaviour = new ChildrenBehaviour(this);
-		}
 
 		public Children(ICollection<Child> initialValues, IComparer<Child> comparer) : base(initialValues, comparer)
 		{

src/NHibernate/Mapping/AbstractAuxiliaryDatabaseObject.cs

@@ -47,7 +47,7 @@ public IDictionary<string, string> Parameters
 		public bool AppliesToDialect(Dialect.Dialect dialect)
 		{
 			// empty means no scoping
-			return dialectScopes.IsEmpty || dialectScopes.Contains(dialect.GetType().FullName);
+			return dialectScopes.Count == 0 || dialectScopes.Contains(dialect.GetType().FullName);
 		}
 
 		public abstract string SqlCreateString(Dialect.Dialect dialect, IMapping p, string defaultCatalog, string defaultSchema);

src/NHibernate/Persister/Collection/AbstractCollectionPersister.cs

@@ -2,7 +2,8 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Data;
-using System.Data.Common;
+using System.Data.Common;
+using System.Linq;
 using System.Text;
 using NHibernate.AdoNet;
 using NHibernate.Cache;
@@ -620,16 +621,12 @@ private ICollectionInitializer GetSubselectInitializer(object key, ISessionImple
 			else
 			{
 				// Take care of any entities that might have
-				// been evicted!
-				List<EntityKey> keysToRemove = new List<EntityKey>(subselect.Result.Count);
-				foreach (EntityKey entityKey in subselect.Result)
-				{
-					if (!persistenceContext.ContainsEntity(entityKey))
-					{
-						keysToRemove.Add(entityKey);
-					}
-				}
-				subselect.Result.RemoveAll(keysToRemove);
+				// been evicted!
+				List<EntityKey> keysToRemove = subselect.Result
+					.Where(entityKey => !persistenceContext.ContainsEntity(entityKey)).ToList();
+
+				foreach (var entityKey in keysToRemove)
+					subselect.Result.Remove(entityKey);
 
 				// Run a subquery loader
 				return CreateSubselectInitializer(subselect, session);