Added suggested optimizations and some more

Author: bahusoid

src/NHibernate/Engine/Query/CallableParser.cs

@@ -21,9 +21,11 @@ public static Detail Parse(string sqlString)
 		{
 			Detail callableDetail = new Detail();
 
-			callableDetail.IsCallable = sqlString.IndexOf('{') == 0 &&
-										sqlString.IndexOf('}') == (sqlString.Length - 1) &&
-										sqlString.IndexOf("call", StringComparison.Ordinal) > 0;
+			int indexOfCall = -1;
+			callableDetail.IsCallable = sqlString.Length > 5 && // to be able to check sqlString[0] we at least need to make sure that string has at least 1 character. The simplest case all other conditions are true is "{call}" which is 6 characters, so check it.
+										sqlString[0] == '{' &&
+										sqlString[sqlString.Length - 1] == '}' &&
+										(indexOfCall = sqlString.IndexOf("call", StringComparison.Ordinal)) > 0;
 
 			if (!callableDetail.IsCallable)
 				return callableDetail;
@@ -35,11 +37,11 @@ public static Detail Parse(string sqlString)
 
 			callableDetail.FunctionName = functionMatch.Groups[1].Value;
 
-			callableDetail.HasReturn = sqlString.IndexOf("call", StringComparison.Ordinal) > 0 &&
+			callableDetail.HasReturn = indexOfCall > 0 &&
 										sqlString.IndexOf('?') > 0 &&
 										sqlString.IndexOf('=') > 0 &&
-										sqlString.IndexOf('?') < sqlString.IndexOf("call", StringComparison.Ordinal) &&
-										sqlString.IndexOf('=') < sqlString.IndexOf("call", StringComparison.Ordinal);
+										sqlString.IndexOf('?') < indexOfCall &&
+										sqlString.IndexOf('=') < indexOfCall;
 
 			return callableDetail;
 		}

src/NHibernate/Engine/Query/ParameterParser.cs

@@ -42,11 +42,12 @@ private ParameterParser()
 		public static void Parse(string sqlString, IRecognizer recognizer)
 		{
 			// TODO: WTF? "CALL"... it may work for ORACLE but what about others RDBMS ? (by FM)
-			bool hasMainOutputParameter = sqlString.IndexOf("call", StringComparison.Ordinal) > 0 &&
+			var indexOfCall = sqlString.IndexOf("call", StringComparison.Ordinal);
+			bool hasMainOutputParameter = indexOfCall > 0 &&
 										  sqlString.IndexOf('?') > 0 &&
 										  sqlString.IndexOf('=') > 0 &&
-										  sqlString.IndexOf('?') < sqlString.IndexOf("call", StringComparison.Ordinal) &&
-										  sqlString.IndexOf('=') < sqlString.IndexOf("call", StringComparison.Ordinal);
+										  sqlString.IndexOf('?') < indexOfCall &&
+										  sqlString.IndexOf('=') < indexOfCall;
 			bool foundMainOutputParam = false;
 
 			int stringLength = sqlString.Length;
@@ -59,7 +60,7 @@ public static void Parse(string sqlString, IRecognizer recognizer)
 				// check comments
 				if (indx + 1 < stringLength && sqlString.Substring(indx,2) == "/*")
 				{
-					var closeCommentIdx = sqlString.IndexOf("*/", indx+2);
+					var closeCommentIdx = sqlString.IndexOf("*/", indx + 2, StringComparison.Ordinal);
 					recognizer.Other(sqlString.Substring(indx, (closeCommentIdx- indx)+2));
 					indx = closeCommentIdx + 1;
 					continue;
@@ -112,7 +113,7 @@ public static void Parse(string sqlString, IRecognizer recognizer)
 					if (c == ':')
 					{
 						// named parameter
-						int right = StringHelper.FirstIndexOfChar(sqlString, ParserHelper.HqlSeparators, indx + 1);
+						int right = StringHelper.FirstIndexOfChar(sqlString, ParserHelper.HqlSeparatorsAsCharArray, indx + 1);
 						int chopLocation = right < 0 ? sqlString.Length : right;
 						string param = sqlString.Substring(indx + 1, chopLocation - (indx + 1));
 						recognizer.NamedParameter(param, indx);
@@ -124,7 +125,7 @@ public static void Parse(string sqlString, IRecognizer recognizer)
 						if (indx < stringLength - 1 && char.IsDigit(sqlString[indx + 1]))
 						{
 							// a peek ahead showed this as an ejb3-positional parameter
-							int right = StringHelper.FirstIndexOfChar(sqlString, ParserHelper.HqlSeparators, indx + 1);
+							int right = StringHelper.FirstIndexOfChar(sqlString, ParserHelper.HqlSeparatorsAsCharArray, indx + 1);
 							int chopLocation = right < 0 ? sqlString.Length : right;
 							string param = sqlString.Substring(indx + 1, chopLocation - (indx + 1));
 							// make sure this "name" is an integral

src/NHibernate/Hql/ParserHelper.cs

@@ -8,6 +8,7 @@ public static class ParserHelper
 		public const string HqlVariablePrefix = ":";
 
 		public const string HqlSeparators = " \n\r\f\t,()=<>&|+-=/*'^![]#~\\;";
+		internal static readonly char[] HqlSeparatorsAsCharArray = HqlSeparators.ToCharArray();
 		//NOTICE: no " or . since they are part of (compound) identifiers
 
 		public const string Whitespace = " \n\r\f\t";

src/NHibernate/Util/StringHelper.cs

@@ -548,7 +548,12 @@ public static string[] Qualify(string prefix, string[] names)
 
 		public static int FirstIndexOfChar(string sqlString, string str, int startIndex)
 		{
-			return sqlString.IndexOfAny(str.ToCharArray(), startIndex);
+			return FirstIndexOfChar(sqlString, str.ToCharArray(), startIndex);
+		}
+		
+		internal static int FirstIndexOfChar(string sqlString, char[] chars, int startIndex)
+		{
+			return sqlString.IndexOfAny(chars, startIndex);
 		}
 
 		public static string Truncate(string str, int length)