Skip to content

Commit 8975071

Browse files
Guidelines for checking automated builds after submitting a pull request.
1 parent d034dc8 commit 8975071

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ Be sure to link to the JIRA issue in your GitHub pull request. Also, go back to
9090

9191
We use tabs for code indentation, not spaces. As this is not the default in Visual Studio, you will need to reconfigure Visual Studio to indent with tabs whenever you work on the NHibernate codebase. To make this easier, NHibernate has an [editorconfig][3] configuration file to switch Visual Studio automatically between tabs and spaces mode. It is recommended you install editorconfig from the Visual Studio Extension Manager.
9292

93+
After submitting your pull request, come back later to check the outcome of automated builds. If some have failed, they will be listed in your pull request with a link to the corresponding TeamCity build. Find out in the build which tests are newly failing, and take appropriate action. Some of those builds have many known failing tests, which does not trigger a build failure. A *Comparison.txt* file in build Artifacts may help finding which failing tests are not known failing tests and must be addressed.
94+
9395
## Further Discussion
9496

9597
The NHibernate team monitors JIRA and GitHub regularly, so your request will be noticed. If you want to discuss it further, you are welcome to post to the [nhibernate-development mailing list][4].

Contributor Guide.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,9 @@ <h2>Submit a Pull Request</h2>
147147
<p>We use tabs for code indentation, not spaces. As this is not the default in Visual Studio, you will need to reconfigure Visual Studio to indent with tabs whenever you work on the NHibernate codebase. To make this easier, NHibernate has an
148148
<a href="http://www.editorconfig.org/">editorconfig</a> configuration file to switch Visual Studio automatically between
149149
tabs and spaces mode. It is recommended you install editorconfig from the Visual Studio Extension Manager.</p>
150+
<p>
151+
After submitting your pull request, come back later to check the outcome of automated builds. If some have failed, they will be listed in your pull request with a link to the corresponding TeamCity build. Find out in the build which tests are newly failing, and take appropriate action. Some of those builds have many known failing tests, which does not trigger a build failure. A <i>Comparison.txt</i> file in build Artifacts may help finding which failing tests are not known failing tests and must be addressed.
152+
</p>
150153

151154
<h2>Further Discussion</h2>
152155

0 commit comments

Comments
 (0)