Jira to GitHub: change issue naming in tests (#1382)

fredericDelaporte · hazzik · commit 8c820c8d0e70 · 2017-10-17T09:26:21.000+13:00
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -45,17 +45,21 @@ In most cases, you will be adding your test to the NHibernate.Test project. If t
 
 1.  Open **NHibernate.sln** from the src folder.
 2.  If adding a C# test, go to the NHSpecificTest folder in the NHibernate.Test project. If adding a VisualBasic test, go to the Issues folder in the NHibernate.Test.VisualBasic project.
-3.  Copy and paste the NH0000 folder to create a duplicate test ("Copy of NH0000").
-4.  Replace the four (five for vb) instances of NH0000 with your issue number.
+3.  Copy and paste the GH0000 folder to create a duplicate test ("Copy of GH0000").
+4.  Replace the four instances of GH0000 with your issue number.
 5.  Edit the test as you see fit. Don't commit yet; there are details in a later step.
 
+Do not use anymore the NHxxxx naming, they match issue numbers from https://nhibernate.jira.com/
+
+NHibernate has migrated its issue tracking from Jira to GitHub, and using the Jira naming may lead to conflicts with previous Jira issues.
+
 ## Running Your Unit Test
 
 ### Debugging Through Included NUnit GUI
 
 1.  Right click on the project (ex. NHibernate.Test) in Visual Studio.
 2.  Select: Debug -> Start New Instance
-3.  Type the name of your unit test to quickly go to it. For example: NH2318
+3.  Type the name of your unit test to quickly go to it. For example: GH2318
 4.  Select and run the test.
 5.  You can also make the test project your startup project and it will run NUnit when you press F5.
 
diff --git a/src/NHibernate.Test.VisualBasic/Issues/GH0000/Entity.vb b/src/NHibernate.Test.VisualBasic/Issues/GH0000/Entity.vb
@@ -1,6 +1,6 @@
 ﻿Namespace Issues
 
-    Namespace NH0000
+    Namespace GH0000
 
         Public Class Entity
 
@@ -28,4 +28,4 @@
 
     End Namespace
 
-End Namespace
+End Namespace
diff --git a/src/NHibernate.Test.VisualBasic/Issues/GH0000/Fixture.vb b/src/NHibernate.Test.VisualBasic/Issues/GH0000/Fixture.vb
@@ -4,7 +4,7 @@ Imports NHibernate.Linq
 
 Namespace Issues
 
-    Namespace NH0000
+    Namespace GH0000
 
         <TestFixture()> _
         Public Class Fixture
diff --git a/src/NHibernate.Test.VisualBasic/Issues/GH0000/Issues.GH0000.Mappings.hbm.xml b/src/NHibernate.Test.VisualBasic/Issues/GH0000/Issues.GH0000.Mappings.hbm.xml
@@ -1,5 +1,5 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test.VisualBasic" namespace="NHibernate.Test.VisualBasic.Issues.NH0000">
+﻿<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test.VisualBasic" namespace="NHibernate.Test.VisualBasic.Issues.GH0000">
 
 	<class name="Entity">
 		<id name="Id">
@@ -8,4 +8,4 @@
 		<property name="Name" />
 	</class>
 
-</hibernate-mapping>
+</hibernate-mapping>
diff --git a/src/NHibernate.Test/Async/NHSpecificTest/GH0000/Fixture.cs b/src/NHibernate.Test/Async/NHSpecificTest/GH0000/Fixture.cs
@@ -12,7 +12,7 @@
 using NHibernate.Linq;
 using NUnit.Framework;
 
-namespace NHibernate.Test.NHSpecificTest.NH0000
+namespace NHibernate.Test.NHSpecificTest.GH0000
 {
 	using System.Threading.Tasks;
 	[TestFixture]
@@ -60,4 +60,4 @@ public async Task YourTestNameAsync()
 			}
 		}
 	}
-}
+}
diff --git a/src/NHibernate.Test/Async/NHSpecificTest/NH2218/Fixture.cs b/src/NHibernate.Test/Async/NHSpecificTest/NH2218/Fixture.cs
@@ -10,7 +10,6 @@
 
 using System.Linq;
 using NHibernate.Linq;
-using NHibernate.Test.NHSpecificTest.NH0000;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH2218
diff --git a/src/NHibernate.Test/NHSpecificTest/GH0000/Entity.cs b/src/NHibernate.Test/NHSpecificTest/GH0000/Entity.cs
@@ -1,10 +1,10 @@
 ﻿using System;
 
-namespace NHibernate.Test.NHSpecificTest.NH0000
+namespace NHibernate.Test.NHSpecificTest.GH0000
 {
 	class Entity
 	{
 		public virtual Guid Id { get; set; }
 		public virtual string Name { get; set; }
 	}
-}
+}
diff --git a/src/NHibernate.Test/NHSpecificTest/GH0000/Fixture.cs b/src/NHibernate.Test/NHSpecificTest/GH0000/Fixture.cs
@@ -2,7 +2,7 @@
 using NHibernate.Linq;
 using NUnit.Framework;
 
-namespace NHibernate.Test.NHSpecificTest.NH0000
+namespace NHibernate.Test.NHSpecificTest.GH0000
 {
 	[TestFixture]
 	public class Fixture : BugTestCase
@@ -49,4 +49,4 @@ public void YourTestName()
 			}
 		}
 	}
-}
+}
diff --git a/src/NHibernate.Test/NHSpecificTest/GH0000/FixtureByCode.cs b/src/NHibernate.Test/NHSpecificTest/GH0000/FixtureByCode.cs
@@ -4,7 +4,7 @@
 using NHibernate.Mapping.ByCode;
 using NUnit.Framework;
 
-namespace NHibernate.Test.NHSpecificTest.NH0000
+namespace NHibernate.Test.NHSpecificTest.GH0000
 {
 	/// <summary>
 	/// Fixture using 'by code' mappings
@@ -70,4 +70,4 @@ public void YourTestName()
 			}
 		}
 	}
-}
+}
diff --git a/src/NHibernate.Test/NHSpecificTest/GH0000/Mappings.hbm.xml b/src/NHibernate.Test/NHSpecificTest/GH0000/Mappings.hbm.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.NH0000">
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.GH0000">
 
 	<class name="Entity">
 		<id name="Id" generator="guid.comb" />
 		<property name="Name" />
 	</class>
 
-</hibernate-mapping>
+</hibernate-mapping>
diff --git a/src/NHibernate.Test/NHSpecificTest/NH2218/Entity.cs b/src/NHibernate.Test/NHSpecificTest/NH2218/Entity.cs
@@ -0,0 +1,10 @@
+﻿using System;
+
+namespace NHibernate.Test.NHSpecificTest.NH2218
+{
+	class Entity
+	{
+		public virtual Guid Id { get; set; }
+		public virtual string Name { get; set; }
+	}
+}
diff --git a/src/NHibernate.Test/NHSpecificTest/NH2218/Fixture.cs b/src/NHibernate.Test/NHSpecificTest/NH2218/Fixture.cs
@@ -1,6 +1,5 @@
 ﻿using System.Linq;
 using NHibernate.Linq;
-using NHibernate.Test.NHSpecificTest.NH0000;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH2218
diff --git a/src/NHibernate.Test/NHSpecificTest/NH2218/Mappings.hbm.xml b/src/NHibernate.Test/NHSpecificTest/NH2218/Mappings.hbm.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.NH0000">
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.NH2218">
 
 	<class name="Entity" entity-name="Entity1">
 		<id name="Id" generator="guid.comb" />

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`using NHibernate.Linq;`
`13`	`13`	`using NUnit.Framework;`
`14`	`14`
`15`		`-namespace NHibernate.Test.NHSpecificTest.NH0000`
	`15`	`+namespace NHibernate.Test.NHSpecificTest.GH0000`
`16`	`16`	`{`
`17`	`17`	`using System.Threading.Tasks;`
`18`	`18`	`[TestFixture]`
`@@ -60,4 +60,4 @@ public async Task YourTestNameAsync()`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`	`}`
`63`		`-}`
	`63`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,10 @@`
`1`	`1`	`using System;`
`2`	`2`
`3`		`-namespace NHibernate.Test.NHSpecificTest.NH0000`
	`3`	`+namespace NHibernate.Test.NHSpecificTest.GH0000`
`4`	`4`	`{`
`5`	`5`	`class Entity`
`6`	`6`	`{`
`7`	`7`	`public virtual Guid Id { get; set; }`
`8`	`8`	`public virtual string Name { get; set; }`
`9`	`9`	`}`
`10`		`-}`
	`10`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`using NHibernate.Linq;`
`3`	`3`	`using NUnit.Framework;`
`4`	`4`
`5`		`-namespace NHibernate.Test.NHSpecificTest.NH0000`
	`5`	`+namespace NHibernate.Test.NHSpecificTest.GH0000`
`6`	`6`	`{`
`7`	`7`	`[TestFixture]`
`8`	`8`	`public class Fixture : BugTestCase`
`@@ -49,4 +49,4 @@ public void YourTestName()`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`	`}`
`52`		`-}`
	`52`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`using NHibernate.Mapping.ByCode;`
`5`	`5`	`using NUnit.Framework;`
`6`	`6`
`7`		`-namespace NHibernate.Test.NHSpecificTest.NH0000`
	`7`	`+namespace NHibernate.Test.NHSpecificTest.GH0000`
`8`	`8`	`{`
`9`	`9`	`/// <summary>`
`10`	`10`	`/// Fixture using 'by code' mappings`
`@@ -70,4 +70,4 @@ public void YourTestName()`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`}`
`73`		`-}`
	`73`	`+}`