Add NetFxOnlyAttribute

Author: maca88

src/NHibernate.Test/Ado/BatcherFixture.cs

@@ -90,13 +90,14 @@ public void OneRoundTripUpdate()
 			Cleanup();
 		}
 
-#if NETFX
-		[Test, Ignore("Not fixed yet.")]
+		[Test, Ignore("Not fixed yet."), NetFxOnly]
 		[Description("SqlClient: The batcher should run all different INSERT queries in only one roundtrip.")]
 		public void SqlClientOneRoundTripForUpdateAndInsert()
 		{
+#if NETFX
 			if (Sfi.Settings.BatcherFactory is SqlClientBatchingBatcherFactory == false)
 				Assert.Ignore("This test is for SqlClientBatchingBatcher only");
+#endif
 
 			FillDb();
 
@@ -129,12 +130,14 @@ public void SqlClientOneRoundTripForUpdateAndInsert()
 			Cleanup();
 		}
 
-		[Test]
+		[Test, NetFxOnly]
 		[Description("SqlClient: The batcher log output should be formatted")]
 		public void BatchedoutputShouldBeFormatted()
 		{
+#if NETFX
 			if (Sfi.Settings.BatcherFactory is SqlClientBatchingBatcherFactory == false)
 				Assert.Ignore("This test is for SqlClientBatchingBatcher only");
+#endif
 
 			using (var sqlLog = new SqlLogSpy())
 			{
@@ -145,7 +148,6 @@ public void BatchedoutputShouldBeFormatted()
 
 			Cleanup();
 		}
-#endif
 
 		[Test]
 		[Description("The batcher should run all DELETE queries in only one roundtrip.")]

src/NHibernate.Test/Async/Ado/BatcherFixture.cs

@@ -102,9 +102,25 @@ public async Task OneRoundTripUpdateAsync()
 			await (CleanupAsync());
 		}
 
+		[Test, NetFxOnly]
+		[Description("SqlClient: The batcher log output should be formatted")]
+		public async Task BatchedoutputShouldBeFormattedAsync()
+		{
 #if NETFX
+			if (Sfi.Settings.BatcherFactory is SqlClientBatchingBatcherFactory == false)
+				Assert.Ignore("This test is for SqlClientBatchingBatcher only");
 #endif
 
+			using (var sqlLog = new SqlLogSpy())
+			{
+				await (FillDbAsync());
+				var log = sqlLog.GetWholeLog();
+				Assert.IsTrue(log.Contains("INSERT \n    INTO"));
+			}
+
+			await (CleanupAsync());
+		}
+
 		[Test]
 		[Description("The batcher should run all DELETE queries in only one roundtrip.")]
 		public async Task OneRoundTripDeleteAsync()

src/NHibernate.Test/Async/Tools/hbm2ddl/SchemaValidator/SchemaValidateFixture.cs

@@ -52,8 +52,34 @@ public async Task ShouldVerifySameTableAsync()
 			await (validator.ValidateAsync());
 		}
 
-#if NETFX
-#endif
+		[Test, SetCulture("tr-TR"), SetUICulture("tr-TR"), NetFxOnly]
+		public async Task ShouldVerifySameTableTurkishAsync()
+		{
+			//NH-3063
+
+			// Turkish have unusual casing rules for the letter 'i'. This test verifies that
+			// code paths executed by the SchemaValidator correctly handles case insensitive
+			// comparisons for this.
+
+			// Just make sure that we have an int property in the mapped class. This is
+			// the 'i' we rely on for the test.
+			var v = new Version();
+			Assert.That(v.Id, Is.TypeOf<int>());
+
+			var cfg = BuildConfiguration(_version1Resource);
+
+			var export = new SchemaExport(cfg);
+			await (export.CreateAsync(true, true));
+			try
+			{
+				var validator = new Tool.hbm2ddl.SchemaValidator(cfg);
+				await (validator.ValidateAsync());
+			}
+			finally
+			{
+				await (export.DropAsync(true, true));
+			}
+		}
 
 		[Test]
 		public void ShouldNotVerifyModifiedTableAsync()

src/NHibernate.Test/DriverTest/ReflectionBasedDriverTest.cs

@@ -64,20 +64,19 @@ public override string NamedPrefix
 			}
 		}
 
-#if NETFX
-		[Test]
+		[Test, NetFxOnly]
 		public void WhenCreatedWithGoodDbProviderThenNotThrows()
 		{
 			Assert.That(() => new MyDriverWithWrongClassesAndGoodDbProviderFactory(), Throws.Nothing);
 		}
 
-		[Test]
+		[Test, NetFxOnly]
 		public void WhenCreatedWithNullAssemblyAndGoodDbProviderThenNotThrows()
 		{
 			Assert.That(() => new MyDriverWithWrongClassesAndGoodDbProviderFactory(null), Throws.Nothing);
 		}
 
-		[Test]
+		[Test, NetFxOnly]
 		public void WhenCreatedWithDbFactoryThenCanReturnConnection()
 		{
 			var provider = new MyDriverWithWrongClassesAndGoodDbProviderFactory();
@@ -87,7 +86,7 @@ public void WhenCreatedWithDbFactoryThenCanReturnConnection()
 			}
 		}
 
-		[Test]
+		[Test, NetFxOnly]
 		public void WhenCreatedWithDbFactoryThenCanReturnCommand()
 		{
 			var provider = new MyDriverWithWrongClassesAndGoodDbProviderFactory();
@@ -96,7 +95,6 @@ public void WhenCreatedWithDbFactoryThenCanReturnCommand()
 				Assert.That(command, Is.Not.Null);
 			}
 		}
-#endif
 
 		[Test]
 		public void WhenCreatedWithNoDbProviderThenNotThrows()

src/NHibernate.Test/NetFxOnlyAttribute.cs

@@ -0,0 +1,20 @@
+using System;
+using NUnit.Framework;
+using NUnit.Framework.Interfaces;
+
+namespace NHibernate.Test
+{
+	public class NetFxOnlyAttribute : Attribute, ITestAction
+	{
+		public ActionTargets Targets => ActionTargets.Default;
+
+		public void AfterTest(ITest test) { }
+
+		public void BeforeTest(ITest test)
+		{
+#if !NETFX
+			Assert.Ignore("This test is only for NETFX.");
+#endif
+		}
+	}
+}

src/NHibernate.Test/Tools/hbm2ddl/SchemaValidator/SchemaValidateFixture.cs

@@ -41,8 +41,7 @@ public void ShouldVerifySameTable()
 			validator.Validate();
 		}
 
-#if NETFX
-		[Test, SetCulture("tr-TR"), SetUICulture("tr-TR")]
+		[Test, SetCulture("tr-TR"), SetUICulture("tr-TR"), NetFxOnly]
 		public void ShouldVerifySameTableTurkish()
 		{
 			//NH-3063
@@ -70,7 +69,6 @@ public void ShouldVerifySameTableTurkish()
 				export.Drop(true, true);
 			}
 		}
-#endif
 
 		[Test]
 		public void ShouldNotVerifyModifiedTable()

src/NHibernate.Test/UtilityTest/ReflectHelperFixture.cs

@@ -82,8 +82,7 @@ public void NoTypeFoundReturnsNull()
 			Assert.IsNull(noType);
 		}
 
-#if NETFX
-		[Test]
+		[Test, NetFxOnly]
 		public void TypeFoundInNotLoadedAssembly()
 		{
 			System.Type httpRequest = ReflectHelper.TypeFromAssembly("System.Web.HttpRequest", "System.Web", false);
@@ -92,7 +91,6 @@ public void TypeFoundInNotLoadedAssembly()
 			System.Type sameType = ReflectHelper.TypeFromAssembly("System.Web.HttpRequest", "System.Web", false);
 			Assert.AreEqual(httpRequest, sameType, "should be the exact same Type");
 		}
-#endif
 
 		[Test]
 		public void SystemTypes()