Proper transient check for proxy

bahusoid · bahusoid · commit a39c14aba9f1 · 2019-03-14T10:58:09.000+02:00
diff --git a/src/NHibernate/Async/Engine/ForeignKeys.cs b/src/NHibernate/Async/Engine/ForeignKeys.cs
@@ -170,7 +170,7 @@ public static async Task<bool> IsNotTransientSlowAsync(string entityName, object
 		public static async Task<bool?> IsTransientFastAsync(string entityName, object entity, ISessionImplementor session, CancellationToken cancellationToken)
 		{
 			cancellationToken.ThrowIfCancellationRequested();
-			if (entity.IsProxy())
+			if (entity is INHibernateProxy proxy && proxy.HibernateLazyInitializer.IsUninitialized)
 				return false;
 
 			if (Equals(Intercept.LazyPropertyInitializer.UnfetchedProperty, entity))
diff --git a/src/NHibernate/Engine/ForeignKeys.cs b/src/NHibernate/Engine/ForeignKeys.cs
@@ -167,7 +167,7 @@ public static bool IsNotTransientSlow(string entityName, object entity, ISession
 		/// </remarks>
 		public static bool? IsTransientFast(string entityName, object entity, ISessionImplementor session)
 		{
-			if (entity.IsProxy())
+			if (entity is INHibernateProxy proxy && proxy.HibernateLazyInitializer.IsUninitialized)
 				return false;
 
 			if (Equals(Intercept.LazyPropertyInitializer.UnfetchedProperty, entity))

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ public static async Task<bool> IsNotTransientSlowAsync(string entityName, object`
`170`	`170`	`public static async Task<bool?> IsTransientFastAsync(string entityName, object entity, ISessionImplementor session, CancellationToken cancellationToken)`
`171`	`171`	`{`
`172`	`172`	`cancellationToken.ThrowIfCancellationRequested();`
`173`		`- if (entity.IsProxy())`
	`173`	`+ if (entity is INHibernateProxy proxy && proxy.HibernateLazyInitializer.IsUninitialized)`
`174`	`174`	`return false;`
`175`	`175`
`176`	`176`	`if (Equals(Intercept.LazyPropertyInitializer.UnfetchedProperty, entity))`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ public static bool IsNotTransientSlow(string entityName, object entity, ISession`
`167`	`167`	`/// </remarks>`
`168`	`168`	`public static bool? IsTransientFast(string entityName, object entity, ISessionImplementor session)`
`169`	`169`	`{`
`170`		`- if (entity.IsProxy())`
	`170`	`+ if (entity is INHibernateProxy proxy && proxy.HibernateLazyInitializer.IsUninitialized)`
`171`	`171`	`return false;`
`172`	`172`
`173`	`173`	`if (Equals(Intercept.LazyPropertyInitializer.UnfetchedProperty, entity))`