Fix a wrong parameter value for query translation

It was not having any impact because concrete used implementations are currently not using its value.

Author: fredericDelaporte

src/NHibernate/Async/Impl/ExpressionQueryImpl.cs

@@ -8,7 +8,6 @@
 //------------------------------------------------------------------------------
 
 
-using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
@@ -26,7 +25,7 @@ namespace NHibernate.Impl
 	using System.Threading.Tasks;
 	using System.Threading;
 
-	partial class ExpressionFilterImpl : ExpressionQueryImpl
+	internal partial class ExpressionFilterImpl : ExpressionQueryImpl
 	{
 
 		public override async Task<IList> ListAsync(CancellationToken cancellationToken = default(CancellationToken))

src/NHibernate/Impl/ExpressionQueryImpl.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
@@ -21,8 +20,17 @@ public ExpressionQueryImpl(IQueryExpression queryExpression, ISessionImplementor
 			QueryExpression = queryExpression;
 		}
 
+		protected ExpressionQueryImpl(
+			IQueryExpression queryExpression, ISessionImplementor session, ParameterMetadata parameterMetadata, bool isFilter)
+			: this(queryExpression, session, parameterMetadata)
+		{
+			_isFilter = isFilter;
+		}
+
 		public IQueryExpression QueryExpression { get; private set; }
 
+		protected readonly bool _isFilter;
+
 		/// <summary> 
 		/// Warning: adds new parameters to the argument by side-effect, as well as mutating the query expression tree!
 		/// </summary>
@@ -68,10 +76,8 @@ protected override IQueryExpression ExpandParameters(IDictionary<string, TypedVa
 
 			//TODO: Do we need to translate expression one more time here?
 			// This is not much an issue anymore: ExpressionQueryImpl are currently created only with NhLinqExpression
-			// which do cache their translation. By the way, the false transmitted below as filter parameter to
-			// Translate is wrong, since this ExpandParameters may also be called from ExpressionFilterImpl.
-			// But that does not matter for NhLinqExpression.
-			var newTree = ParameterExpander.Expand(QueryExpression.Translate(Session.Factory, false), map);
+			// which do cache their translation.
+			var newTree = ParameterExpander.Expand(QueryExpression.Translate(Session.Factory, _isFilter), map);
 			var key = new StringBuilder(QueryExpression.Key);
 
 			foreach (var pair in map)
@@ -87,12 +93,12 @@ protected override IQueryExpression ExpandParameters(IDictionary<string, TypedVa
 		}
 	}
 
-	partial class ExpressionFilterImpl : ExpressionQueryImpl
+	internal partial class ExpressionFilterImpl : ExpressionQueryImpl
 	{
 		private readonly object collection;
 
 		public ExpressionFilterImpl(IQueryExpression queryExpression, object collection, ISessionImplementor session, ParameterMetadata parameterMetadata) 
-			: base(queryExpression, session, parameterMetadata)
+			: base(queryExpression, session, parameterMetadata, true)
 		{
 			this.collection = collection;
 		}