Skip to content

Commit bfa41be

Browse files
Add a todo about convert
To be squashed
1 parent cd3fc04 commit bfa41be

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/NHibernate/Type/TimeAsTimeSpanType.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ public override object Get(DbDataReader rs, int index, ISessionImplementor sessi
4646
if (value is TimeSpan time) //For those dialects where DbType.Time means TimeSpan.
4747
return time;
4848

49+
// Todo: investigate if this convert should be made culture invariant, here and in other NHibernate types,
50+
// such as AbstractDateTimeType and TimeType, or even in all other places doing such converts in NHibernate.
4951
var dbValue = Convert.ToDateTime(value);
5052
return dbValue.TimeOfDay;
5153
}

0 commit comments

Comments
 (0)