Skip to content

Commit c3c98e8

Browse files
committed
Avoid aliases to SqlString conversion
1 parent d8dc1b1 commit c3c98e8

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/NHibernate/Criterion/Order.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ public Order(string propertyName, bool ascending)
3636
/// </summary>
3737
public virtual SqlString ToSqlString(ICriteria criteria, ICriteriaQuery criteriaQuery)
3838
{
39-
SqlString[] columns = GetColumnsOrAliases(criteria, criteriaQuery);
39+
var columnsOrAliases = GetColumnsOrAliases(criteria, criteriaQuery);
4040
bool[] toLowerColumns = ignoreCase ? FindStringColumns(criteria, criteriaQuery) : null;
4141

4242
var fragment = new SqlStringBuilder();
4343
var factory = criteriaQuery.Factory;
44-
for (int i = 0; i < columns.Length; i++)
44+
for (int i = 0; i < columnsOrAliases.Length; i++)
4545
{
4646
bool lower = toLowerColumns?[i] == true;
4747

@@ -52,7 +52,7 @@ public virtual SqlString ToSqlString(ICriteria criteria, ICriteriaQuery criteria
5252
.Add("(");
5353
}
5454

55-
fragment.Add(columns[i]);
55+
fragment.AddObject(columnsOrAliases[i]);
5656

5757
if (lower)
5858
{
@@ -61,7 +61,7 @@ public virtual SqlString ToSqlString(ICriteria criteria, ICriteriaQuery criteria
6161

6262
fragment.Add(ascending ? " asc" : " desc");
6363

64-
if (i < columns.Length - 1)
64+
if (i < columnsOrAliases.Length - 1)
6565
{
6666
fragment.Add(", ");
6767
}
@@ -70,12 +70,12 @@ public virtual SqlString ToSqlString(ICriteria criteria, ICriteriaQuery criteria
7070
return fragment.ToSqlString();
7171
}
7272

73-
private SqlString[] GetColumnsOrAliases(ICriteria criteria, ICriteriaQuery criteriaQuery)
73+
private object[] GetColumnsOrAliases(ICriteria criteria, ICriteriaQuery criteriaQuery)
7474
{
7575
var propName = propertyName ?? (projection as IPropertyProjection)?.PropertyName;
7676
return propName != null
77-
? Array.ConvertAll(criteriaQuery.GetColumnAliasesUsingProjection(criteria, propName), x => new SqlString(x))
78-
: CriterionUtil.GetColumnNamesUsingProjection(projection, criteriaQuery, criteria);
77+
? criteriaQuery.GetColumnAliasesUsingProjection(criteria, propName)
78+
: (object[]) CriterionUtil.GetColumnNamesUsingProjection(projection, criteriaQuery, criteria);
7979
}
8080

8181
private bool[] FindStringColumns(ICriteria criteria, ICriteriaQuery criteriaQuery)

0 commit comments

Comments
 (0)