NH-4061 - test case for pointless take causing failures with Oracle dialect.

Author: fredericDelaporte

src/NHibernate.Test/Linq/MiscellaneousTextFixture.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Linq;
 using System.Linq.Expressions;
+using NHibernate.Dialect;
 using NHibernate.Linq;
 using NHibernate.DomainModel.Northwind.Entities;
 using NUnit.Framework;
@@ -92,8 +93,8 @@ where p.ProductId > 1
 				orderby p.ProductId
 				select p;
 
-			// ToList required otherwise the First call alters the paging and test something else than paging three pages.
-			// (And Skip().Take().First() causes a bug with Oracle.)
+			// ToList required otherwise the First call alters the paging and test something else than paging three pages,
+			// contrary o the test above description.
 			var page2 = q.Skip(5).Take(5).ToList();
 			var page3 = q.Skip(10).Take(5).ToList();
 			var page4 = q.Skip(15).Take(5).ToList();
@@ -107,7 +108,30 @@ orderby p.ProductId
 			Assert.AreNotEqual(firstResultOnPage2.ProductId, firstResultOnPage4.ProductId);
 		}
 
-        [Test]
+		[Category("Paging")]
+		[Test(Description = "NH-4061 - This sample uses a where clause and the Skip and Take operators to select " +
+			"the second, third and fourth pages of products, but then add a First causing the Take to be pointless.")]
+		public void TriplePageSelectionWithFirst()
+		{
+			if (Dialect is Oracle8iDialect)
+				Assert.Ignore("Not fixed: NH-4061 - Pointless Take calls screw Oracle dialect paging.");
+
+			var q =
+				from p in db.Products
+				where p.ProductId > 1
+				orderby p.ProductId
+				select p;
+
+			var firstResultOnPage2 = q.Skip(5).Take(5).First();
+			var firstResultOnPage3 = q.Skip(10).Take(5).First();
+			var firstResultOnPage4 = q.Skip(15).Take(5).First();
+
+			Assert.AreNotEqual(firstResultOnPage2.ProductId, firstResultOnPage3.ProductId);
+			Assert.AreNotEqual(firstResultOnPage3.ProductId, firstResultOnPage4.ProductId);
+			Assert.AreNotEqual(firstResultOnPage2.ProductId, firstResultOnPage4.ProductId);
+		}
+
+		[Test]
         public void SelectFromObject()
         {
             using (var s = OpenSession())