Workaround for Firebird not immediately dropping objects added to more test cases.

Author: fredericDelaporte

src/NHibernate.Test/CfgTest/ConfigurationSerializationTests.cs

@@ -85,18 +85,7 @@ public void Basic_CRUD_should_work()
 				Assert.That(p, Is.Null);
 			}
 
-			if (((ISessionFactoryImplementor) sf).ConnectionProvider.Driver is FirebirdClientDriver fbDriver)
-			{
-				// Firebird will pool each connection created during the test and will marked as used any table
-				// referenced by queries. It will at best delays those tables drop until connections are actually
-				// closed, or immediately fail dropping them.
-				// This results in other tests failing when they try to create tables with same name.
-				// By clearing the connection pool the tables will get dropped. This is done by the following code.
-				// Moved from NH1908 test case, contributed by Amro El-Fakharany.
-				fbDriver.ClearPool(null);
-			}
-
-			export.Drop(true, true);
+			TestCase.DropSchema(true, export, (ISessionFactoryImplementor)sf);
 		}
 	}
-}
+}

src/NHibernate.Test/Linq/LinqReadonlyTestsContext.cs

@@ -8,6 +8,7 @@
 using NHibernate.Connection;
 using NHibernate.Tool.hbm2ddl;
 using NUnit.Framework;
+using NHibernate.Engine;
 
 namespace NHibernate.Test.Linq
 {
@@ -96,7 +97,8 @@ public void DestroyNorthwindDb()
 			}
 			else
 			{
-				new SchemaExport(configuration).Drop(false, true);
+				using (var sf = configuration.BuildSessionFactory())
+					TestCase.DropSchema(false, new SchemaExport(configuration), (ISessionFactoryImplementor)sf);
 			}
 		}
 
@@ -143,4 +145,4 @@ private void CreateTestData(ISessionFactory sessionFactory)
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/NHSpecificTest/NH1710/Fixture.cs

@@ -38,7 +38,7 @@ public void NotIgnorePrecisionScaleInSchemaExport()
 			var script = new StringBuilder();
 			new SchemaExport(cfg).Create(sl => script.AppendLine(sl), true);
 			Assert.That(script.ToString(), Does.Contain(expectedExportString));
-			new SchemaExport(cfg).Drop(false, true);
+			TestCase.DropSchema(false, new SchemaExport(cfg), factory);
 		}
 
 		private Dialect.Dialect GetDialect()

src/NHibernate.Test/NHSpecificTest/NH4004/Fixture.cs

@@ -2,7 +2,6 @@
 using NHibernate.Cfg.MappingSchema;
 using NHibernate.Dialect;
 using NHibernate.Mapping.ByCode;
-using NHibernate.Tool.hbm2ddl;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH4004
@@ -45,7 +44,7 @@ protected override bool CheckDatabaseWasCleaned()
 		[Test]
 		public void SequenceShallBeDropped()
 		{
-			new SchemaExport(cfg).Drop(true, true);
+			DropSchema();
 
 			using (var connection = Sfi.ConnectionProvider.GetConnection())
 			{
@@ -58,4 +57,4 @@ public void SequenceShallBeDropped()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/TestCase.cs

@@ -276,7 +276,12 @@ protected virtual void CreateSchema()
 
 		protected virtual void DropSchema()
 		{
-			if (Sfi?.ConnectionProvider.Driver is FirebirdClientDriver fbDriver)
+			DropSchema(OutputDdl, new SchemaExport(cfg), Sfi);
+		}
+
+		public static void DropSchema(bool useStdOut, SchemaExport export, ISessionFactoryImplementor sfi)
+		{
+			if (sfi?.ConnectionProvider.Driver is FirebirdClientDriver fbDriver)
 			{
 				// Firebird will pool each connection created during the test and will marked as used any table
 				// referenced by queries. It will at best delays those tables drop until connections are actually
@@ -287,7 +292,7 @@ protected virtual void DropSchema()
 				fbDriver.ClearPool(null);
 			}
 
-			new SchemaExport(cfg).Drop(OutputDdl, true);
+			export.Drop(useStdOut, true);
 		}
 
 		protected virtual DebugSessionFactory BuildSessionFactory()

src/NHibernate.Test/Tools/hbm2ddl/SchemaMetadataUpdaterTest/SchemaMetadataUpdaterFixture.cs

@@ -248,7 +248,7 @@ public void CanWorkWithAutoQuoteTableAndColumnsAtStratup()
 				t.Commit();
 			}
 
-			new SchemaExport(configuration).Drop(false, true);
+			TestCase.DropSchema(false, new SchemaExport(configuration), (ISessionFactoryImplementor)sf);
 		}
 
 		[Test]
@@ -285,4 +285,4 @@ public void WhenConfiguredOnlyExplicitAutoQuote()
 			Assert.That(!GetColumnByName(culs, "Name").IsQuoted);
 		}
 	}
-}
+}