NH-2167, NH-3609, NH-3797, NH-3801, NH-3844 - Disable tests not supported by Firebird

Author: hazzik

src/NHibernate.Test/Linq/ByMethod/GroupByTests.cs

@@ -531,20 +531,29 @@ into grp
 		[Test(Description = "NH-3797")]
 		public void GroupByComputedValue()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.Orders.GroupBy(o => o.Customer.CustomerId == null ? 0 : 1).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(830, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3797")]
 		public void GroupByComputedValueInAnonymousType()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.Orders.GroupBy(o => new { Key = o.Customer.CustomerId == null ? 0 : 1 }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(830, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3797")]
 		public void GroupByComputedValueInObjectArray()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.Orders.GroupBy(o => new[] { o.Customer.CustomerId == null ? 0 : 1, }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(830, orderGroups.Sum(g => g.Count));
 		}
@@ -669,62 +678,89 @@ public void GroupByKeyWithConstantFromVariable()
 		[Test(Description = "NH-3801")]
 		public void GroupByComputedValueWithJoinOnObject()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.GroupBy(o => o.Order.Customer == null ? 0 : 1).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3801")]
 		public void GroupByComputedValueWithJoinOnId()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.GroupBy(o => o.Order.Customer.CustomerId == null ? 0 : 1).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3801")]
 		public void GroupByComputedValueInAnonymousTypeWithJoinOnObject()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.GroupBy(o => new { Key = o.Order.Customer == null ? 0 : 1 }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3801")]
 		public void GroupByComputedValueInAnonymousTypeWithJoinOnId()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.GroupBy(o => new { Key = o.Order.Customer.CustomerId == null ? 0 : 1 }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3801")]
 		public void GroupByComputedValueInObjectArrayWithJoinOnObject()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.GroupBy(o => new[] { o.Order.Customer == null ? 0 : 1 }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3801")]
 		public void GroupByComputedValueInObjectArrayWithJoinOnId()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.GroupBy(o => new[] { o.Order.Customer.CustomerId == null ? 0 : 1 }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3801")]
 		public void GroupByComputedValueInObjectArrayWithJoinInRightSideOfCase()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.GroupBy(o => new[] { o.Order.Customer.CustomerId == null ? "unknown" : o.Order.Customer.CompanyName }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3844")]
 		public void GroupByComputedValueFromNestedArraySelect()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.Select(o => new object[] { o }).GroupBy(x => new object[] { ((OrderLine)x[0]).Order.Customer == null ? 0 : 1 }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}
 
 		[Test(Description = "NH-3844")]
 		public void GroupByComputedValueFromNestedObjectSelect()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			var orderGroups = db.OrderLines.Select(o => new { OrderLine = (object)o }).GroupBy(x => new object[] { ((OrderLine)x.OrderLine).Order.Customer == null ? 0 : 1 }).Select(g => new { Key = g.Key, Count = g.Count() }).ToList();
 			Assert.AreEqual(2155, orderGroups.Sum(g => g.Count));
 		}

src/NHibernate.Test/NHSpecificTest/NH2167/Fixture.cs

@@ -1,12 +1,18 @@
 using NHibernate.Cfg.MappingSchema;
 using NHibernate.Criterion;
+using NHibernate.Dialect;
 using NHibernate.Mapping.ByCode;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH2167
 {
 	public class Fixture : TestCaseMappingByCode
 	{
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			return !(dialect is FirebirdDialect);
+		}
+
 		protected override HbmMapping GetMappings()
 		{
 			var mapper = new ModelMapper();

src/NHibernate.Test/NHSpecificTest/NH3609/Fixture.cs

@@ -1,4 +1,5 @@
 using NHibernate.Criterion;
+using NHibernate.Dialect;
 using NHibernate.Transform;
 using NUnit.Framework;
 
@@ -82,6 +83,9 @@ public void CountWithConditionalDoesNotThrow()
 		[Test]
 		public void GroupByClauseHasParameterSet()
 		{
+			if (Dialect is FirebirdDialect)
+				Assert.Ignore("Firebird does not support complex group by expressions");
+
 			using (var session = OpenSession())
 			using (session.BeginTransaction())
 			{

src/NHibernate.Test/NHSpecificTest/NH3844/Fixture.cs

@@ -6,6 +6,7 @@
 using System.Reflection;
 using System.Text;
 using System.Threading;
+using NHibernate.Dialect;
 using NHibernate.Linq;
 using NHibernate.Test.ExceptionsTest;
 using NHibernate.Test.MappingByCode;
@@ -16,6 +17,11 @@ namespace NHibernate.Test.NHSpecificTest.NH3844
 	[TestFixture]
 	public class Fixture : BugTestCase
 	{
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			return !(dialect is FirebirdDialect);
+		}
+
 		protected override void OnSetUp()
 		{
 			var job1 = new Job { Name = "Not a Job", BillingType = BillingType.None };