Replace remaining SetOptions with WithOptions (#1434)

Author: hazzik

.editorconfig

@@ -20,6 +20,13 @@ indent_size = 2
 indent_style = space
 indent_size = 2
 
+[*.csproj]
+indent_style = space
+indent_size = 2
+
+[*.vbproj]
+indent_style = space
+indent_size = 2
 
 [*.cshtml]
 indent_style = space

src/NHibernate.Test/Async/Futures/LinqFutureFixture.cs

@@ -397,7 +397,7 @@ public async Task UsingManyParametersAndQueries_DoesNotCauseParameterNameCollisi
 					{
 						query = query.Where(x => x.Age > j);
 					}
-					list.Add(query.SetOptions(x => x.SetCacheable(true)).ToFuture());
+					list.Add(query.WithOptions(x => x.SetCacheable(true)).ToFuture());
 				}
 				foreach (var query in list)
 				{

src/NHibernate.Test/Futures/LinqFutureFixture.cs

@@ -386,7 +386,7 @@ public void UsingManyParametersAndQueries_DoesNotCauseParameterNameCollisions()
 					{
 						query = query.Where(x => x.Age > j);
 					}
-					list.Add(query.SetOptions(x => x.SetCacheable(true)).ToFuture());
+					list.Add(query.WithOptions(x => x.SetCacheable(true)).ToFuture());
 				}
 				foreach (var query in list)
 				{

src/NHibernate/NHibernate.csproj

@@ -9,14 +9,11 @@
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
     <AssemblyOriginatorKeyFile>..\NHibernate.snk</AssemblyOriginatorKeyFile>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
+    <TreatSpecificWarningsAsErrors />
 
     <PackageDescription>NHibernate is a mature, open source object-relational mapper for the .NET framework. It is actively developed, fully featured and used in thousands of successful projects.</PackageDescription>
     <PackageTags>ORM; O/RM; DataBase; DAL; ObjectRelationalMapping; NHibernate; ADO.Net; Core</PackageTags>
- </PropertyGroup>
-
-  <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
-    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
-    <TreatSpecificWarningsAsErrors />
   </PropertyGroup>
 
   <ItemGroup>