Add test case for deletion of component with null property

Demonstrate #1170 - Incorrect query when items removed from a collection
of components contain null values

Author: fredericDelaporte

src/NHibernate.Test/Async/NHSpecificTest/GH1170/Fixture.cs

@@ -0,0 +1,70 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by AsyncGenerator.
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+
+using System.Linq;
+using NUnit.Framework;
+using NHibernate.Linq;
+
+namespace NHibernate.Test.NHSpecificTest.GH1170
+{
+	using System.Threading.Tasks;
+	[TestFixture]
+	public class FixtureAsync : BugTestCase
+	{
+		[Test, KnownBug("GH1170")]
+		public async Task DeleteComponentWithNullAsync()
+		{
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var parent = await (session.Query<Parent>().SingleAsync());
+				Assert.That(
+					parent.ChildComponents,
+					Has.Count.EqualTo(2).And.One.Property(nameof(ChildComponent.SomeString)).Null);
+				parent.ChildComponents.Remove(parent.ChildComponents.Single(c => c.SomeString == null));
+				await (tx.CommitAsync());
+			}
+
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var parent = await (session.Query<Parent>().SingleAsync());
+				Assert.That(
+					parent.ChildComponents,
+					Has.Count.EqualTo(1).And.None.Property(nameof(ChildComponent.SomeString)).Null);
+				await (tx.CommitAsync());
+			}
+		}
+
+		protected override void OnSetUp()
+		{
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var parent = new Parent();
+				parent.ChildComponents.Add(new ChildComponent { SomeBool = true, SomeString = "something" });
+				parent.ChildComponents.Add(new ChildComponent { SomeBool = false, SomeString = null });
+				session.Save(parent);
+
+				tx.Commit();
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				session.Delete("from Parent");
+				tx.Commit();
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH1170/Fixture.cs

@@ -0,0 +1,58 @@
+using System.Linq;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.GH1170
+{
+	[TestFixture]
+	public class Fixture : BugTestCase
+	{
+		[Test, KnownBug("GH1170")]
+		public void DeleteComponentWithNull()
+		{
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var parent = session.Query<Parent>().Single();
+				Assert.That(
+					parent.ChildComponents,
+					Has.Count.EqualTo(2).And.One.Property(nameof(ChildComponent.SomeString)).Null);
+				parent.ChildComponents.Remove(parent.ChildComponents.Single(c => c.SomeString == null));
+				tx.Commit();
+			}
+
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var parent = session.Query<Parent>().Single();
+				Assert.That(
+					parent.ChildComponents,
+					Has.Count.EqualTo(1).And.None.Property(nameof(ChildComponent.SomeString)).Null);
+				tx.Commit();
+			}
+		}
+
+		protected override void OnSetUp()
+		{
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var parent = new Parent();
+				parent.ChildComponents.Add(new ChildComponent { SomeBool = true, SomeString = "something" });
+				parent.ChildComponents.Add(new ChildComponent { SomeBool = false, SomeString = null });
+				session.Save(parent);
+
+				tx.Commit();
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				session.Delete("from Parent");
+				tx.Commit();
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH1170/Mappings.hbm.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2"
+                   assembly="NHibernate.Test"
+                   namespace="NHibernate.Test.NHSpecificTest.GH1170">
+  <class name="Parent">
+    <id name="Id" column="id_column_of_parent">
+      <generator class="guid" />
+    </id>
+    <set name="ChildComponents">
+      <key column="key_column_of_child" />
+      <composite-element class="ChildComponent">
+        <property name="SomeBool" />
+        <property name="SomeString" />
+      </composite-element>
+    </set>
+  </class>
+</hibernate-mapping>

src/NHibernate.Test/NHSpecificTest/GH1170/Model.cs

@@ -0,0 +1,22 @@
+using System;
+using System.Collections.Generic;
+
+namespace NHibernate.Test.NHSpecificTest.GH1170
+{
+	public class Parent
+	{
+		public Parent()
+		{
+			ChildComponents = new List<ChildComponent>();
+		}
+
+		public virtual ICollection<ChildComponent> ChildComponents { get; set; }
+		public virtual Guid Id { get; set; }
+	}
+
+	public class ChildComponent
+	{
+		public virtual bool SomeBool { get; set; }
+		public virtual string SomeString { get; set; }
+	}
+}