No need to distinct for simple assigment

bahusoid · bahusoid · commit f7fedbc24a98 · 2022-10-26T15:48:09.000+03:00
diff --git a/src/NHibernate/Hql/Ast/ANTLR/Tree/JoinSubqueryFromElement.cs b/src/NHibernate/Hql/Ast/ANTLR/Tree/JoinSubqueryFromElement.cs
@@ -21,10 +21,10 @@ public JoinSubqueryFromElement(FromClause fromClause, QueryNode queryNode, JoinT
 			QueryNode = queryNode;
 			DataType = dataType;
 			foreach (var fromElement in querySelectClause.SelectExpressions.Select(o => o.FromElement)
-				.Concat(querySelectClause.NonScalarExpressions?.Select(o => o.FromElement) ?? Enumerable.Empty<FromElement>())
-				.Concat(querySelectClause.CollectionFromElements ?? Enumerable.Empty<FromElement>())
+				.Concat(querySelectClause.NonScalarExpressions?.Select(o => o.FromElement) ?? Array.Empty<FromElement>())
+				.Concat(querySelectClause.CollectionFromElements ?? Array.Empty<FromElement>())
 				.Where(o => o != null)
-				.Distinct())
+				)
 			{
 				fromElement.ParentFromElement = this;
 			}

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,10 @@ public JoinSubqueryFromElement(FromClause fromClause, QueryNode queryNode, JoinT`
`21`	`21`	`QueryNode = queryNode;`
`22`	`22`	`DataType = dataType;`
`23`	`23`	`foreach (var fromElement in querySelectClause.SelectExpressions.Select(o => o.FromElement)`
`24`		`- .Concat(querySelectClause.NonScalarExpressions?.Select(o => o.FromElement) ?? Enumerable.Empty<FromElement>())`
`25`		`- .Concat(querySelectClause.CollectionFromElements ?? Enumerable.Empty<FromElement>())`
	`24`	`+ .Concat(querySelectClause.NonScalarExpressions?.Select(o => o.FromElement) ?? Array.Empty<FromElement>())`
	`25`	`+ .Concat(querySelectClause.CollectionFromElements ?? Array.Empty<FromElement>())`
`26`	`26`	`.Where(o => o != null)`
`27`		`- .Distinct())`
	`27`	`+ )`
`28`	`28`	`{`
`29`	`29`	`fromElement.ParentFromElement = this;`
`30`	`30`	`}`