NH-4058 - Fix Oracle (12c) Managed 32 failing tests.

Author: fredericDelaporte

lib/teamcity/oracle-managed/NHibernate.Test.last-results.xml

@@ -33,7 +33,12 @@ namespace NHibernate.Test
 	/// <remarks>Sessions opened from other sessions are not tracked.</remarks>
 	public class DebugSessionFactory : ISessionFactoryImplementor
 	{
-		public DebugConnectionProvider ConnectionProvider { get; }
+		/// <summary>
+		/// The debug connection provider if configured for using it, <see langword="null"/> otherwise.
+		/// Use <c>ActualFactory.ConnectionProvider</c> if needing unconditionally the connection provider, be
+		/// it debug or not.
+		/// </summary>
+		public DebugConnectionProvider DebugConnectionProvider { get; }
 		public ISessionFactoryImplementor ActualFactory { get; }
 
 		public EventListeners EventListeners => ((SessionFactoryImpl)ActualFactory).EventListeners;
@@ -44,7 +49,7 @@ public class DebugSessionFactory : ISessionFactoryImplementor
 		public DebugSessionFactory(ISessionFactory actualFactory)
 		{
 			ActualFactory = (ISessionFactoryImplementor)actualFactory;
-			ConnectionProvider = ActualFactory.ConnectionProvider as DebugConnectionProvider;
+			DebugConnectionProvider = ActualFactory.ConnectionProvider as DebugConnectionProvider;
 		}
 
 		#region Session tracking

src/NHibernate.Test/DebugSessionFactory.cs

@@ -76,10 +76,13 @@ public void DialectSQLFunctions()
 				rset = s.CreateQuery("select abs(round(s.Pay)) from s in class Simple").List();
 				Assert.AreEqual(46f, rset[0], "abs(round(-45.8)) result was incorrect");
 
+				/* As of NH-3893, left and right functions are broken. Seemed confused with join keyword, and not
+				   supported on Hibernate side.
 				rset = s.CreateQuery("select left('abc', 2), right('abc', 2) from s in class Simple").List();
 				row = (object[]) rset[0];
 				Assert.AreEqual("ab", row[0], "Left function is broken.");
 				Assert.AreEqual("bc", row[1], "Right function is broken.");
+				*/
 
 				// Test a larger depth 3 function example - Not a useful combo other than for testing
 				Assert.AreEqual(1,

src/NHibernate.Test/Legacy/SQLFunctionsTest.cs

@@ -86,16 +86,17 @@ public void ReferenceToOuter()
 							"the second, third and fourth pages of products")]
 		public void TriplePageSelection()
 		{
-			IQueryable<Product> q = (
-			                        	from p in db.Products
-			                        	where p.ProductId > 1
-			                        	orderby p.ProductId
-			                        	select p
-			);
-
-            IQueryable<Product> page2 = q.Skip(5).Take(5);
-            IQueryable<Product> page3 = q.Skip(10).Take(5);
-            IQueryable<Product> page4 = q.Skip(15).Take(5);
+			var q =
+				from p in db.Products
+				where p.ProductId > 1
+				orderby p.ProductId
+				select p;
+
+			// ToList required otherwise the First call alters the paging and test something else than paging three pages.
+			// (And Skip().Take().First() causes a bug with Oracle.)
+			var page2 = q.Skip(5).Take(5).ToList();
+			var page3 = q.Skip(10).Take(5).ToList();
+			var page4 = q.Skip(15).Take(5).ToList();
 
 			var firstResultOnPage2 = page2.First();
 			var firstResultOnPage3 = page3.First();

src/NHibernate.Test/Linq/MiscellaneousTextFixture.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using NHibernate.Criterion;
+using NHibernate.Dialect;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH1792
@@ -79,6 +80,11 @@ public void PageWithDetachedCriteriaSubqueryWithOrderBy()
 		[Test]
 		public void PageWithRawSqlSubqueryWithOrderBy()
 		{
+			// Theoretically, the ordering of elements in a "where col in (elements)" should not change anything.
+			// That is not the case for SQL Server, but Oracle just refuses any ordering there.
+			if (Dialect is Oracle8iDialect)
+				Assert.Ignore("Oracle does not support pointless order by");
+
 			using (ISession session = OpenSession())
 			{
 				string top = "";

src/NHibernate.Test/NHSpecificTest/NH1792/Fixture.cs

@@ -1,13 +1,18 @@
-using System;
-using System.Data.Common;
 using NHibernate.Connection;
+using NHibernate.Dialect;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH1985
 {
 	[TestFixture]
 	public class SampleTest : BugTestCase
 	{
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			// Test written with raw SQL queries, not compatible with all databases.
+			return dialect is MsSql2000Dialect;
+		}
+
 		protected override void OnSetUp()
 		{
 			if (0 == ExecuteStatement("INSERT INTO DomainClass (Id, Label) VALUES (1, 'TEST record');"))

src/NHibernate.Test/NHSpecificTest/NH1985/SampleTest.cs

@@ -77,7 +77,7 @@ public void PagTest()
 		[Test]
 		public void PagingWithLock_NH2255()
 		{
-			if (Dialect is Oracle12cDialect)
+			if (Dialect is Oracle8iDialect)
 				Assert.Ignore(@"Oracle does not support row_limiting_clause with for_update_clause
 See: https://docs.oracle.com/database/121/SQLRF/statements_10002.htm#BABHFGAA");
 

src/NHibernate.Test/Pagination/PaginationFixture.cs

@@ -301,11 +301,13 @@ public void SimpleProjections()
 			Assert.That(es.FetchCount, Is.EqualTo(0)); //check that it was being cached
 		}
 
-		public class CustomTransformer: IResultTransformer
+		public class CustomTransformer : IResultTransformer
 		{
 			public object TransformTuple(object[] tuple, string[] aliases)
 			{
-				return new AnotherItem {Name = tuple[0].ToString(), Description = tuple[1].ToString()};
+				// Some db change the empty string to null, causing .ToString() to blow.
+				// https://stackoverflow.com/a/203536/1178314
+				return new AnotherItem { Name = tuple[0]?.ToString(), Description = tuple[1]?.ToString() };
 			}
 
 			public IList TransformList(IList collection)

src/NHibernate.Test/SecondLevelCacheTest/QueryCacheFixture.cs

@@ -1,10 +1,19 @@
 using System.Collections;
+using NHibernate.Dialect;
 using NUnit.Framework;
 
 namespace NHibernate.Test.Subselect
 {
 	public class ClassSubselectFixture: TestCase
 	{
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			// Oracle does not support the union of the literal 'human' with an Unicode column. Typing the column AnsiString does not
+			// solve the issue because it is mapped to Oracle varchar2 which can still be Unicode, depending on the server configuration.
+			// Using the literal N'human' breaks some other databases, not supporting the "N" prefix.
+			return !(Dialect is Oracle8iDialect);
+		}
+
 		protected override IList Mappings
 		{
 			get { return new[] {"Subselect.Beings.hbm.xml"}; }

src/NHibernate.Test/Subselect/ClassSubselectFixture.cs

@@ -238,13 +238,13 @@ protected virtual bool CheckDatabaseWasCleaned()
 
 		private bool CheckConnectionsWereClosed()
 		{
-			if (_sessionFactory?.ConnectionProvider?.HasOpenConnections != true)
+			if (_sessionFactory?.DebugConnectionProvider?.HasOpenConnections != true)
 			{
 				return true;
 			}
 
 			log.Error("Test case didn't close all open connections, closing");
-			_sessionFactory.ConnectionProvider.CloseAllConnections();
+			_sessionFactory.DebugConnectionProvider.CloseAllConnections();
 			return false;
 		}
 
@@ -292,7 +292,12 @@ protected virtual void DropSchema()
 
 		protected virtual DebugSessionFactory BuildSessionFactory()
 		{
-			return new DebugSessionFactory(cfg.BuildSessionFactory());
+			var factory = new DebugSessionFactory(cfg.BuildSessionFactory());
+			// Avoid ORA-12704 in tests, due to NHibernate defaulting String to NVarchar2 when creating tables while
+			// ODP.Net defaults it to Varchar2 (which does support Unicode too, depending on server) for parameters.
+			if (factory.ActualFactory.ConnectionProvider.Driver is OracleManagedDataClientDriver oracleManagedDriver)
+				oracleManagedDriver.UseNVarchar2ForStringParameter = true;
+			return factory;
 		}
 
 		private void Cleanup()

src/NHibernate.Test/TestCase.cs

@@ -40,6 +40,9 @@ public void Equals()
 		[Test]
 		public void ReadWrite()
 		{
+			if (Dialect is Oracle8iDialect)
+				Assert.Ignore("The Oracle dialect maps currency as Number(20, 2), this test can only fail.");
+
 			const decimal expected = 5.6435M;
 
 			var basic = new CurrencyClass {CurrencyValue = expected};

src/NHibernate.Test/TypesTest/CurrencyTypeFixture.cs

@@ -22,7 +22,8 @@ public class OracleManagedDataClientDriver : ReflectionBasedDriver, IEmbeddedBat
 		private readonly PropertyInfo oracleDbType;
 		private readonly object oracleDbTypeRefCursor;
 		private readonly object oracleDbTypeXmlType;
-        private readonly object oracleDbTypeBlob;
+		private readonly object oracleDbTypeBlob;
+		private readonly object _oracleDbTypeNVarchar2;
 
 		/// <summary>
 		/// Initializes a new instance of <see cref="OracleDataClientDriver"/>.
@@ -47,8 +48,31 @@ public OracleManagedDataClientDriver()
 			oracleDbTypeRefCursor = Enum.Parse(oracleDbTypeEnum, "RefCursor");
 			oracleDbTypeXmlType = Enum.Parse(oracleDbTypeEnum, "XmlType");
 			oracleDbTypeBlob = Enum.Parse(oracleDbTypeEnum, "Blob");
+			_oracleDbTypeNVarchar2 = Enum.Parse(oracleDbTypeEnum, "NVarchar2");
 		}
 
+		/// <summary>
+		/// By default, ODP.Net maps <see cref="DbType.String"/> to <c>OracleDbType.Varchar2</c>. If you need it to be mapped
+		/// to <c>OracleDbType.NVarchar2</c> instead, set this property to <see langword="true"/>.
+		/// </summary>
+		/// <remarks>
+		/// <para>
+		/// This is not a bug. Varchar2 with Oracle can be Unicode, depending on the server configuration. If the server is
+		/// configured for having it Unicode, Varchar2 should be used for Unicode string. NVarchar2 is there for allowing
+		/// storing Unicode string on server not configured for Unicode.
+		/// http://docs.oracle.com/cd/E51173_01/win.122/e17732/featOraCommand.htm#i1007432
+		/// </para>
+		/// <para>
+		/// So the default NHibernate choice in Oracle dialects to map <see cref="DbType.String"/> to <c>nvarchar2</c> is a bit
+		/// unfortunate, because this is not the default mapping for Oracle. For tests, since the database is created by NHibernate,
+		/// string columns get typed <c>nvarchar2</c>, but parameters are still typed <c>varchar2</c>, causing an
+		/// <c>ORA-12704: character set mismatch</c> for some queries. This being not even reported, I guess most NHibernate Oracle
+		/// users handles their tables themselves and types them with <c>varchar2</c>, avoiding the trouble. So changing the behavior
+		/// for parameters type would be a major breaking change.
+		/// </para>
+		/// </remarks>
+		public bool UseNVarchar2ForStringParameter { get; set; }
+
 		/// <summary></summary>
 		public override string NamedPrefix
 		{
@@ -84,11 +108,17 @@ protected override void InitializeParameter(DbParameter dbParam, string name, Sq
 					base.InitializeParameter(dbParam, name, GuidSqlType);
 					break;
 				case DbType.Xml:
-					this.InitializeParameter(dbParam, name, oracleDbTypeXmlType);
+					InitializeParameter(dbParam, name, oracleDbTypeXmlType);
+					break;
+				case DbType.Binary:
+					InitializeParameter(dbParam, name, oracleDbTypeBlob);
+					break;
+				case DbType.String:
+					if (UseNVarchar2ForStringParameter)
+						InitializeParameter(dbParam, name, _oracleDbTypeNVarchar2);
+					else
+						base.InitializeParameter(dbParam, name, sqlType);
 					break;
-                case DbType.Binary:
-                    this.InitializeParameter(dbParam, name, oracleDbTypeBlob);
-                    break;
 				default:
 					base.InitializeParameter(dbParam, name, sqlType);
 					break;

src/NHibernate/Driver/OracleManagedDataClientDriver.cs

@@ -191,8 +191,6 @@
 				<include name="*.dll"/>
 			</fileset>
 		</copy>
-		<property name="NHibernate.Test.IgnoreFail" value="true" />
-		<property name="teamcity.last.result" value="${root.dir}/lib/teamcity/oracle-managed/NHibernate.Test.last-results.xml" />
 	</target>
 
 	<target name="setup-teamcity-oracle-managed64">
@@ -210,8 +208,6 @@
 				<include name="*.dll"/>
 			</fileset>
 		</copy>
-		<property name="NHibernate.Test.IgnoreFail" value="true" />
-		<property name="teamcity.last.result" value="${root.dir}/lib/teamcity/oracle-managed/NHibernate.Test.last-results.xml" />
 	</target>
 
 	<target name="setup-teamcity-mysql">