Skip to content

NH-3575 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Linq;
using NHibernate.Criterion;
using NHibernate.Impl;
using NUnit.Framework;
Expand All @@ -7,6 +8,20 @@ namespace NHibernate.Test.NHSpecificTest.Futures
[TestFixture]
public class FutureCriteriaFixture : FutureFixture
{
[Test]
public void DefaultReadOnlyTest()
{
//NH-3575
using (var s = sessions.OpenSession())
{
s.DefaultReadOnly = true;

var persons = s.CreateCriteria(typeof(Person)).Future<Person>();

Assert.IsTrue(persons.All(p => s.IsReadOnly(p)));
}
}

[Test]
public void CanUseFutureCriteria()
{
Expand Down
17 changes: 16 additions & 1 deletion src/NHibernate.Test/NHSpecificTest/Futures/FutureQueryFixture.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using NHibernate.Driver;
using System.Linq;
using NHibernate.Driver;
using NHibernate.Impl;
using NUnit.Framework;

Expand All @@ -9,6 +10,20 @@ namespace NHibernate.Test.NHSpecificTest.Futures
[TestFixture]
public class FutureQueryFixture : FutureFixture
{
[Test]
public void DefaultReadOnlyTest()
{
//NH-3575
using (var s = sessions.OpenSession())
{
s.DefaultReadOnly = true;

var persons = s.CreateQuery("from Person").Future<Person>();

Assert.IsTrue(persons.All(p => s.IsReadOnly(p)));
}
}

[Test]
public void CanUseFutureQuery()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Linq;
using NHibernate.Criterion;
using NHibernate.Impl;
using NUnit.Framework;
Expand Down Expand Up @@ -30,6 +31,20 @@ protected override void OnTearDown()
}
}

[Test]
public void DefaultReadOnlyTest()
{
//NH-3575
using (var s = sessions.OpenSession())
{
s.DefaultReadOnly = true;

var persons = s.QueryOver<Person>().Future<Person>();

Assert.IsTrue(persons.All(p => s.IsReadOnly(p)));
}
}

[Test]
public void CanUseFutureCriteria()
{
Expand Down
14 changes: 14 additions & 0 deletions src/NHibernate.Test/NHSpecificTest/Futures/LinqFutureFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,20 @@ namespace NHibernate.Test.NHSpecificTest.Futures
[TestFixture]
public class LinqFutureFixture : FutureFixture
{
[Test]
public void DefaultReadOnlyTest()
{
//NH-3575
using (var s = sessions.OpenSession())
{
s.DefaultReadOnly = true;

var persons = s.Query<Person>().ToFuture();

Assert.IsTrue(persons.All(p => s.IsReadOnly(p)));
}
}

[Test]
public void CoalesceShouldWorkForFutures()
{
Expand Down
2 changes: 1 addition & 1 deletion src/NHibernate/Impl/MultiCriteriaImpl.cs
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ private void GetResultsFromDatabase(IList results)
for (int i = 0; i < loaders.Count; i++)
{
CriteriaLoader loader = loaders[i];
loader.InitializeEntitiesAndCollections(hydratedObjects[i], reader, session, false);
loader.InitializeEntitiesAndCollections(hydratedObjects[i], reader, session, session.DefaultReadOnly);

if (createSubselects[i])
{
Expand Down