bug symfony#27734 [Cache] ArrayAdapter and NullAdapter don't need stampede protection (Pierre Rineau)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Cache] ArrayAdapter and NullAdapter don't need stampede protection

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | probably
| Fixed tickets | symfony#27734 symfony#27731
| License       | MIT

Cf. issues.

Commits
-------

3178aed [Cache] ArrayAdapter and NullAdapter don't need stampede protection

Author: nicolas-grekas

src/Symfony/Component/Cache/Adapter/ArrayAdapter.php

@@ -17,15 +17,13 @@
 use Symfony\Component\Cache\CacheItem;
 use Symfony\Component\Cache\ResettableInterface;
 use Symfony\Component\Cache\Traits\ArrayTrait;
-use Symfony\Component\Cache\Traits\GetTrait;
 
 /**
  * @author Nicolas Grekas <[email protected]>
  */
 class ArrayAdapter implements AdapterInterface, CacheInterface, LoggerAwareInterface, ResettableInterface
 {
     use ArrayTrait;
-    use GetTrait;
 
     private $createCacheItem;
 
@@ -51,6 +49,21 @@ function ($key, $value, $isHit) use ($defaultLifetime) {
         );
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function get(string $key, callable $callback, float $beta = null)
+    {
+        $item = $this->getItem($key);
+
+        // ArrayAdapter works in memory, we don't care about stampede protection
+        if (INF === $beta || !$item->isHit()) {
+            $this->save($item->set($callback($item)));
+        }
+
+        return $item->get();
+    }
+
     /**
      * {@inheritdoc}
      */

src/Symfony/Component/Cache/Adapter/NullAdapter.php

@@ -14,15 +14,12 @@
 use Psr\Cache\CacheItemInterface;
 use Symfony\Component\Cache\CacheInterface;
 use Symfony\Component\Cache\CacheItem;
-use Symfony\Component\Cache\Traits\GetTrait;
 
 /**
  * @author Titouan Galopin <[email protected]>
  */
 class NullAdapter implements AdapterInterface, CacheInterface
 {
-    use GetTrait;
-
     private $createCacheItem;
 
     public function __construct()
@@ -40,6 +37,14 @@ function ($key) {
         );
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function get(string $key, callable $callback, float $beta = null)
+    {
+        return $callback(($this->createCacheItem)());
+    }
+
     /**
      * {@inheritdoc}
      */