Create namespace of attribtue as close to attribute's element as possible

nielsdos · nielsdos · commit 33b9d2db7c15 · 2023-12-28T23:02:57.000+01:00
diff --git a/ext/dom/namespace_compat.c b/ext/dom/namespace_compat.c
@@ -49,8 +49,7 @@ static xmlAttrPtr dom_ns_compat_mark_attribute(xmlNodePtr node, xmlNsPtr ns)
 		name = BAD_CAST "xmlns";
 	}
 
-	// TODO: why on the root?
-	xmlNsPtr xmlns_ns = dom_ns_create_local_as_is(node->doc, xmlDocGetRootElement(node->doc), node, DOM_XMLNS_NS_URI, prefix);
+	xmlNsPtr xmlns_ns = dom_ns_create_local_as_is(node->doc, node, node, DOM_XMLNS_NS_URI, prefix);
 	return xmlSetNsProp(node, xmlns_ns, name, ns->href);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,7 @@ static xmlAttrPtr dom_ns_compat_mark_attribute(xmlNodePtr node, xmlNsPtr ns)`
`49`	`49`	`name = BAD_CAST "xmlns";`
`50`	`50`	`}`
`51`	`51`
`52`		`- // TODO: why on the root?`
`53`		`- xmlNsPtr xmlns_ns = dom_ns_create_local_as_is(node->doc, xmlDocGetRootElement(node->doc), node, DOM_XMLNS_NS_URI, prefix);`
	`52`	`+ xmlNsPtr xmlns_ns = dom_ns_create_local_as_is(node->doc, node, node, DOM_XMLNS_NS_URI, prefix);`
`54`	`53`	`return xmlSetNsProp(node, xmlns_ns, name, ns->href);`
`55`	`54`	`}`
`56`	`55`