Skip to content

Commit 2634f55

Browse files
committed
Merge branch 'PHP-5.4'
* PHP-5.4: Fix bug #63240 on stream_get_line()
2 parents 1d87ad8 + f8e26d9 commit 2634f55

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
--TEST--
2+
Bug #63240: stream_get_line() return contains delimiter string
3+
--FILE--
4+
<?php
5+
$fd = fopen('php://temp', 'r+');
6+
$delimiter = 'MM';
7+
$str = str_repeat('.', 8191) . $delimiter . "rest";
8+
fwrite($fd, $str);
9+
rewind($fd);
10+
$line = stream_get_line($fd, 9000, $delimiter);
11+
var_dump(strlen($line));
12+
$line = stream_get_line($fd, 9000, $delimiter);
13+
var_dump($line);
14+
?>
15+
--EXPECT--
16+
int(8191)
17+
string(4) "rest"

main/streams/streams.c

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,9 +1055,17 @@ PHPAPI char *php_stream_get_record(php_stream *stream, size_t maxlen, size_t *re
10551055
if (has_delim) {
10561056
/* search for delimiter, but skip buffered_len (the number of bytes
10571057
* buffered before this loop iteration), as they have already been
1058-
* searched for the delimiter */
1058+
* searched for the delimiter.
1059+
* The left part of the delimiter may still remain in the buffer,
1060+
* so subtract up to <delim_len - 1> from buffered_len, which is
1061+
* the ammount of data we skip on this search as an optimization
1062+
*/
10591063
found_delim = _php_stream_search_delim(
1060-
stream, maxlen, buffered_len, delim, delim_len TSRMLS_CC);
1064+
stream, maxlen,
1065+
buffered_len >= (delim_len - 1)
1066+
? buffered_len - (delim_len - 1)
1067+
: 0,
1068+
delim, delim_len TSRMLS_CC);
10611069
if (found_delim) {
10621070
break;
10631071
}

0 commit comments

Comments
 (0)