we need to end copiedArgs

klebertarcisio · web-flow · commit caaf989c8190 · 2020-04-12T21:41:22.000-03:00
we need to end copiedArgs. In fact, why do we need copyargs?
diff --git a/CoreFoundation/String.subproj/CFString.c b/CoreFoundation/String.subproj/CFString.c
@@ -7004,7 +7004,8 @@ static Boolean __CFStringAppendFormatCore(CFMutableStringRef outputString, CFStr
 	    newMaxArgNum = specs[curSpec].widthArgNum;
 	}
 	if (sizeArgNum < newMaxArgNum) {
-	    if (specs != localSpecsBuffer) CFAllocatorDeallocate(tmpAlloc, specs);
+	    if (numConfigs > 0) va_end(copiedArgs);
+	    if (specs != localSpecsBuffer) CFAllocatorDeallocate(tmpAlloc, specs);	
 	    if (values != localValuesBuffer) CFAllocatorDeallocate(tmpAlloc, values);
 	    if (formatChars && (formatChars != localFormatBuffer)) CFAllocatorDeallocate(tmpAlloc, formatChars);
             

Original file line number	Diff line number	Diff line change
`@@ -7004,7 +7004,8 @@ static Boolean __CFStringAppendFormatCore(CFMutableStringRef outputString, CFStr`
`7004`	`7004`	`newMaxArgNum = specs[curSpec].widthArgNum;`
`7005`	`7005`	`}`
`7006`	`7006`	`if (sizeArgNum < newMaxArgNum) {`
`7007`		`- if (specs != localSpecsBuffer) CFAllocatorDeallocate(tmpAlloc, specs);`
	`7007`	`+ if (numConfigs > 0) va_end(copiedArgs);`
	`7008`	`+ if (specs != localSpecsBuffer) CFAllocatorDeallocate(tmpAlloc, specs);`
`7008`	`7009`	`if (values != localValuesBuffer) CFAllocatorDeallocate(tmpAlloc, values);`
`7009`	`7010`	`if (formatChars && (formatChars != localFormatBuffer)) CFAllocatorDeallocate(tmpAlloc, formatChars);`
`7010`	`7011`