Adjust to libc updates and drop some of the cfg conditions.

This is a best effort of conditionalizing the InterfaceFlags by
grepping in libc source code.

It looks like support for destination and broadcast addresses has
been added to most if not all BSD variants. Therefore, cfg conditions
have been removed. Let's try and see where this fails.

Author: Markus Wanner (mwa)

src/ifaddrs.rs

@@ -45,21 +45,12 @@ impl InterfaceAddress {
             destination: None,
         };
 
-        #[cfg(any(target_os = "linux", target_os = "emscripten", target_os = "fuchsia"))]
-        {
-            let ifo = unsafe { SockAddr::from_libc_sockaddr(info.ifa_ifu) };
-            if addr.flags.contains(IFF_POINTOPOINT) {
-                addr.destination = ifo;
-            } else if addr.flags.contains(IFF_BROADCAST) {
-                addr.broadcast = ifo;
-            }
+        let ifo = unsafe { SockAddr::from_libc_sockaddr(info.ifa_ifu) };
+        if addr.flags.contains(IFF_POINTOPOINT) {
+            addr.destination = ifo;
         }
-
-        #[cfg(any(target_os = "macos", target_os = "ios", target_os = "freebsd",
-                    target_os = "dragonfly", target_os = "openbsd", target_os = "netbsd",
-                    target_os = "bitrig", target_os = "solaris"))]
-        {
-            addr.destination = unsafe { SockAddr::from_libc_sockaddr(info.ifa_dstaddr) };
+        if addr.flags.contains(IFF_BROADCAST) {
+            addr.broadcast = ifo;
         }
 
         addr

src/net/if_.rs

@@ -21,36 +21,28 @@ pub fn if_nametoindex<P: ?Sized + NixPath>(name: &P) -> Result<c_uint> {
 libc_bitflags!(
     /// Standard interface flags, used by `getifaddrs`
     pub struct InterfaceFlags: libc::c_int {
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_UP;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_BROADCAST;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_DEBUG;
         IFF_LOOPBACK;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_POINTOPOINT;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
+        #[cfg(not(any(target_os = "freebsd", target_os = "dragonfly", target_os = "haiku")))]
         IFF_NOTRAILERS;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
+        #[cfg(not(any(target_os = "freebsd", target_os = "haiku")))]
         IFF_RUNNING;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_NOARP;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_PROMISC;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_ALLMULTI;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
+        #[cfg(any(target_os = "linux", target_os = "android", target_os = "fuchsia"))]
         IFF_MASTER;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
+        #[cfg(any(target_os = "linux", target_os = "android", target_os = "fuchsia"))]
         IFF_SLAVE;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
         IFF_MULTICAST;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
+        #[cfg(any(target_os = "linux", target_os = "android", target_os = "fuchsia"))]
         IFF_PORTSEL;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
+        #[cfg(any(target_os = "linux", target_os = "android", target_os = "fuchsia"))]
         IFF_AUTOMEDIA;
-        #[cfg(any(target_os = "linux", target_os = "android"))]
+        #[cfg(any(target_os = "linux", target_os = "android", target_os = "fuchsia"))]
         IFF_DYNAMIC;
     }
 );