address remarks

Author: devnexen

src/fcntl.rs

@@ -802,7 +802,7 @@ pub enum FcntlArg<'a> {
     F_RDADVISE(libc::radvisory),
     /// Pre-allocate storage with different policies on fd.
     #[cfg(apple_targets)]
-    F_PREALLOCATE(&mut 'a libc::fstore_t),
+    F_PREALLOCATE(&'a mut libc::fstore_t),
     // TODO: Rest of flags
 }
 

test/test_fcntl.rs

@@ -585,19 +585,18 @@ fn test_f_get_path() {
 #[test]
 fn test_f_preallocate() {
     use nix::fcntl::*;
-    use std::os::unix::io::AsRawFd;
 
     let tmp = NamedTempFile::new().unwrap();
-    let fd = tmp.as_raw_fd();
     let mut st: libc::fstore_t = unsafe { std::mem::zeroed() };
 
     st.fst_flags = libc::F_ALLOCATECONTIG as libc::c_uint;
     st.fst_posmode = libc::F_PEOFPOSMODE;
     st.fst_length = 1024;
     let res =
-        fcntl(fd, FcntlArg::F_PREALLOCATE(&st)).expect("preallocation failed");
+        fcntl(tmp, FcntlArg::F_PREALLOCATE(&mut st)).expect("preallocation failed");
 
     assert_eq!(res, 0);
+    assert!(st.fst_bytesalloc > 0);
 }
 
 #[cfg(apple_targets)]