Small fixes to RELEASE_PROCEDURE.md #425
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha, a difference of style opinion! I don't mind how this goes. Adding |
|
I only found references 'eg' in lists of 'internet slang' or 'internet abbreviations'. If I remember correctly, I once read in an english style guide/english grammar, that there is no reason not to write 'for example' instead of 'e.g.', the same holding for 'i.e.' and 'that is' :) |
|
UK style is typically not to put periods. Eg, Guardian style guide: http://www.theguardian.com/guardian-observer-style-guide-a Anyway, @homu r+ |
|
📌 Commit f8d5f38 has been approved by |
homu
added a commit
that referenced
this pull request
Sep 9, 2016
Small fixes to RELEASE_PROCEDURE.md I decided against adding a line for a local test of the commit, because we have the full build in the CI and you might miss something locally anyway.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided against adding a line for a local test of the commit, because we have the full build in the CI and you might miss something locally anyway.