Skip to content

Mark nix::sys::ptrace::ptrace as unsafe, add safe variants of some routines #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 11, 2017
Merged

Mark nix::sys::ptrace::ptrace as unsafe, add safe variants of some routines #709

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b03011f
Mark nix::sys::ptrace::ptrace as unsafe, add safe variants of source …
marmistrz Jul 26, 2017
843eeb0
Improve the documentation of wrappers.
marmistrz Jul 27, 2017
0fbac87
support delivering a signal with ptrace::cont
marmistrz Jul 31, 2017
5510bf2
Add tests for ptrace::cont
marmistrz Jul 31, 2017
9e0d241
Possibly fix tests failing on qemu architectures.
marmistrz Jul 31, 2017
c65b5ba
Add a line break.
marmistrz Jul 31, 2017
cf3c2ad
Extra doc
marmistrz Jul 31, 2017
932f6e0
Reword the comment.
marmistrz Aug 2, 2017
f4a0099
Update changelog
marmistrz Aug 3, 2017
9ad235c
Refactor the changelog
marmistrz Aug 3, 2017
ebcedb3
Merge remote-tracking branch 'upstream/master' into ptrace-noreg
marmistrz Aug 3, 2017
0587977
Deprecate `ptrace`.
marmistrz Aug 10, 2017
d8968f4
Merge remote-tracking branch 'upstream/master' into ptrace-noreg
marmistrz Aug 10, 2017
abcec0f
Remove the incorrect doc comment.
marmistrz Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/sys/test_ptrace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ fn test_ptrace_cont() {

// FIXME: qemu-user doesn't implement ptrace on all arches and gives ENOSYS then.
// use it to filter out the affected platforms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these comments could use proper punctuation and capitalization.

// on valid platforms it will return Errno::EPERM
let err = ptrace::attach(getpid()).unwrap_err();
if err == Error::Sys(Errno::ENOSYS) {
return;
Expand Down