Enabled integ test case for incompatible deps, polished some exception messages

Author: Ao Guo

src/sagemaker/remote_function/core/serialization.py

@@ -41,7 +41,7 @@ def serialize_func_to_s3(func: Callable, sagemaker_session, s3_uri, s3_kms_key=N
     except Exception as e:
         raise SerializationError(
             "Error when serializing function [{}]: {}".format(
-                getattr(func, "__name__", repr(func)), e
+                getattr(func, "__name__", repr(func)), repr(e)
             )
         ) from e
 
@@ -69,7 +69,9 @@ def deserialize_func_from_s3(sagemaker_session, s3_uri) -> Callable:
         return cloudpickle.loads(bytes_to_deserialize)
     except Exception as e:
         raise DeserializationError(
-            "Error when deserializing bytes downloaded from {}: {}".format(s3_uri, e)
+            "Error when deserializing bytes downloaded from {} to function: {}".format(
+                s3_uri, repr(e)
+            )
         ) from e
 
 
@@ -89,7 +91,7 @@ def serialize_obj_to_s3(obj: Any, sagemaker_session, s3_uri: str, s3_kms_key: st
         bytes_to_upload = cloudpickle.dumps(obj)
     except Exception as e:
         raise SerializationError(
-            "Error when serializing object of type [{}]: {}".format(type(obj).__name__, e)
+            "Error when serializing object of type [{}]: {}".format(type(obj).__name__, repr(e))
         ) from e
 
     _upload_bytes_to_s3(bytes_to_upload, s3_uri, s3_kms_key, sagemaker_session)
@@ -113,7 +115,7 @@ def deserialize_obj_from_s3(sagemaker_session, s3_uri) -> Any:
         return cloudpickle.loads(bytes_to_deserialize)
     except Exception as e:
         raise DeserializationError(
-            "Error when deserializing bytes downloaded from {}: {}".format(s3_uri, e)
+            "Error when deserializing bytes downloaded from {}: {}".format(s3_uri, repr(e))
         ) from e
 
 
@@ -124,12 +126,16 @@ def _upload_bytes_to_s3(bytes, s3_uri, s3_kms_key, sagemaker_session):
             bytes, s3_uri, kms_key=s3_kms_key, sagemaker_session=sagemaker_session
         )
     except Exception as e:
-        raise ServiceError("Failed to upload serialized bytes to {}: {}".format(s3_uri, e)) from e
+        raise ServiceError(
+            "Failed to upload serialized bytes to {}: {}".format(s3_uri, repr(e))
+        ) from e
 
 
 def _read_bytes_from_s3(s3_uri, sagemaker_session):
     """Wrapping s3 downloading with exception translation for remote function."""
     try:
         return S3Downloader.read_bytes(s3_uri, sagemaker_session=sagemaker_session)
     except Exception as e:
-        raise ServiceError("Failed to read serialized bytes from {}: {}".format(s3_uri, e)) from e
+        raise ServiceError(
+            "Failed to read serialized bytes from {}: {}".format(s3_uri, repr(e))
+        ) from e

tests/data/remote_function/old_deps_requirements.txt

@@ -0,0 +1 @@
+pandas==1.3.4

tests/integ/sagemaker/remote_function/test_decorator.py

@@ -15,9 +15,10 @@
 
 import pytest
 import os
+import pandas as pd
 
 from sagemaker.remote_function import remote
-from sagemaker.remote_function.errors import RuntimeEnvironmentError
+from sagemaker.remote_function.errors import DeserializationError, RuntimeEnvironmentError
 
 from tests.integ.kms_utils import get_or_create_kms_key
 from tests.integ import DATA_DIR
@@ -136,20 +137,32 @@ def divide(x, y):
         divide(10, 2)
 
 
-@pytest.mark.skip
 def test_with_incompatible_dependencies(
     sagemaker_session, dummy_container_without_error, cpu_instance_type
 ):
+
+    dependencies_path = os.path.join(DATA_DIR, "remote_function/old_deps_requirements.txt")
+
     @remote(
         role=ROLE,
         image_uri=dummy_container_without_error,
-        dependencies="./requirements.txt",
+        dependencies=dependencies_path,
         instance_type=cpu_instance_type,
         sagemaker_session=sagemaker_session,
     )
-    def divide(x, y):
-        return x / y
+    def mul_ten(df: pd.DataFrame):
+        print("hehehe")
+        print(pd.__version__)
+        return df.mul(10)
+
+    df1 = pd.DataFrame(
+        {
+            "A": [14, 4, 5, 4, 1],
+            "B": [5, 2, 54, 3, 2],
+            "C": [20, 20, 7, 3, 8],
+            "D": [14, 3, 6, 2, 6],
+        }
+    )
 
-    # TODO: this should raise DeserializationError
-    with pytest.raises(RuntimeError):
-        divide(10, 2)
+    with pytest.raises(DeserializationError):
+        mul_ten(df1)

tests/integ/sagemaker/remote_function/test_executor.py

@@ -12,7 +12,6 @@
 # language governing permissions and limitations under the License.
 from __future__ import absolute_import
 
-
 from sagemaker.remote_function import RemoteExecutor
 
 ROLE = "SageMakerRole"

tests/unit/sagemaker/remote_function/core/test_serialization.py

@@ -84,7 +84,7 @@ def square(x):
 
     with pytest.raises(
         SerializationError,
-        match=r"Error when serializing function \[square\]: some failure when dumps",
+        match=r"Error when serializing function \[square\]: RuntimeError\('some failure when dumps'\)",
     ):
         serialize_func_to_s3(
             func=square, sagemaker_session=Mock(), s3_uri=s3_uri, s3_kms_key=KMS_KEY
@@ -95,7 +95,8 @@ def square(x):
 
     with pytest.raises(
         DeserializationError,
-        match=rf"Error when deserializing bytes downloaded from {s3_uri}: some failure when loads",
+        match=rf"Error when deserializing bytes downloaded from {s3_uri} to function: "
+        + r"RuntimeError\('some failure when loads'\)",
     ):
         deserialize_func_from_s3(sagemaker_session=Mock(), s3_uri=s3_uri)
     mock_cloudpickle_loads.assert_called_with({})
@@ -116,7 +117,7 @@ def test_serialize_deserialize_lambda_func_serialization_error(
 
     with pytest.raises(
         SerializationError,
-        match=r"Error when serializing function \[<lambda>\]: some failure when dumps",
+        match=r"Error when serializing function \[<lambda>\]: RuntimeError\('some failure when dumps'\)",
     ):
         serialize_func_to_s3(
             func=my_func, sagemaker_session=Mock(), s3_uri=s3_uri, s3_kms_key=KMS_KEY
@@ -127,7 +128,8 @@ def test_serialize_deserialize_lambda_func_serialization_error(
 
     with pytest.raises(
         DeserializationError,
-        match=rf"Error when deserializing bytes downloaded from {s3_uri}: some failure when loads",
+        match=rf"Error when deserializing bytes downloaded from {s3_uri} to function: "
+        + r"RuntimeError\('some failure when loads'\)",
     ):
         deserialize_func_from_s3(sagemaker_session=Mock(), s3_uri=s3_uri)
     mock_cloudpickle_loads.assert_called_with({})
@@ -199,7 +201,7 @@ def __init__(self, x):
 
     with pytest.raises(
         SerializationError,
-        match=r"Error when serializing object of type \[MyData\]: some failure when dumps",
+        match=r"Error when serializing object of type \[MyData\]: RuntimeError\('some failure when dumps'\)",
     ):
         serialize_obj_to_s3(
             obj=my_data, sagemaker_session=Mock(), s3_uri=s3_uri, s3_kms_key=KMS_KEY
@@ -211,7 +213,7 @@ def __init__(self, x):
 
     with pytest.raises(
         DeserializationError,
-        match=rf"Error when deserializing bytes downloaded from {s3_uri}: some failure when loads",
+        match=rf"Error when deserializing bytes downloaded from {s3_uri}: RuntimeError\('some failure when loads'\)",
     ):
         deserialize_obj_from_s3(sagemaker_session=Mock(), s3_uri=s3_uri)
     mock_cloudpickle_loads.assert_called_with({})
@@ -226,7 +228,7 @@ def test_serialize_deserialize_service_error():
     s3_uri = random_s3_uri()
     with pytest.raises(
         ServiceError,
-        match=rf"Failed to upload serialized bytes to {s3_uri}: some failure when upload_bytes",
+        match=rf"Failed to upload serialized bytes to {s3_uri}: RuntimeError\('some failure when upload_bytes'\)",
     ):
         serialize_func_to_s3(
             func=my_func, sagemaker_session=Mock(), s3_uri=s3_uri, s3_kms_key=KMS_KEY
@@ -236,6 +238,6 @@ def test_serialize_deserialize_service_error():
 
     with pytest.raises(
         ServiceError,
-        match=rf"Failed to read serialized bytes from {s3_uri}: some failure when read_bytes",
+        match=rf"Failed to read serialized bytes from {s3_uri}: RuntimeError\('some failure when read_bytes'\)",
     ):
         deserialize_func_from_s3(sagemaker_session=Mock(), s3_uri=s3_uri)

tests/unit/sagemaker/remote_function/test_client.py

@@ -193,7 +193,7 @@ def square(x):
 
     with pytest.raises(
         ServiceError,
-        match=r"Failed to read serialized bytes from .+: some error when reading from s3",
+        match=r"Failed to read serialized bytes from .+: RuntimeError\('some error when reading from s3'\)",
     ):
         square(5)
 
@@ -224,7 +224,7 @@ def square(x):
     with pytest.raises(
         DeserializationError,
         match=r"Error when deserializing bytes downloaded from .+: "
-        "some value error when deserializing",
+        r"ValueError\('some value error when deserializing'\)",
     ):
         square(5)
     assert MockJobSettings.call_args.kwargs["image_uri"] == IMAGE
@@ -738,7 +738,7 @@ def test_future_get_result_from_failed_job_local_error_service_error(mock_start,
 
     with pytest.raises(
         ServiceError,
-        match=r"Failed to read serialized bytes from .+: some error when reading from s3",
+        match=r"Failed to read serialized bytes from .+: RuntimeError\('some error when reading from s3'\)",
     ):
         future.result()
 
@@ -770,7 +770,7 @@ def test_future_get_result_from_failed_job_local_error_remote_function_error(
     with pytest.raises(
         DeserializationError,
         match=r"Error when deserializing bytes downloaded from .+: "
-        "some value error when deserializing",
+        r"ValueError\('some value error when deserializing'\)",
     ):
         future.result()