-
Notifications
You must be signed in to change notification settings - Fork 9
Setup test environment #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ovflowd can I have your opinion ? |
I need clarification ont this yet. After we accomplish the initial migration parts, we can add unit testing. But should we also have end-to-end testing? Like a sample doc, we grab from node/node to test against? 🤔 I think it'd make sense to compile a list of what we want to test |
For me we need these tests:
So my advice would be to set up the test environment before migrating anything from |
I'm +1 on adding the tests when we need them (i.e. in the same pr for #2 or one after). Before then I don't really see how it'd help |
Feel free to add tests! |
Setting up a test environment would allow each function to be tested individually in order to ensure stability throughout the project.
To do this, I suggest using vitest, which is faster and more stable than jest. And it wraps the environment for Preact.
Should we use nodejs test-runner? Honestly, I think not, because if we have to test web components with tailwind and css module and typescript, it gets really complicated with nodejs test-runner.
We'll also need to set up GitHub actions to retrieve the test coverage.
The text was updated successfully, but these errors were encountered: