Skip to content

Commit 93bd6d1

Browse files
authored
chore(node-pr): various fixes and updates for the node PR script (#5817)
1 parent ef42996 commit 93bd6d1

File tree

9 files changed

+1508
-240
lines changed

9 files changed

+1508
-240
lines changed

.github/workflows/create-cli-deps-pr.yml

Lines changed: 0 additions & 97 deletions
This file was deleted.

.github/workflows/create-node-pr.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ on:
99
description: "The npm spec to create the PR from"
1010
required: true
1111
default: 'latest'
12+
branch:
13+
description: "The major node version to serve as the base of the PR. Should be `main` or a number like `18`, `19`, etc."
14+
required: true
15+
default: 'main'
1216
dryRun:
1317
description: "Setting this to anything will run all the steps except opening the PR"
1418

@@ -23,6 +27,8 @@ jobs:
2327
steps:
2428
- name: Checkout
2529
uses: actions/checkout@v3
30+
with:
31+
fetch-depth: 0
2632
- name: Setup Git User
2733
run: |
2834
git config --global user.email "[email protected]"
@@ -46,4 +52,4 @@ jobs:
4652
GITHUB_TOKEN: ${{ secrets.NODE_PULL_REQUEST_TOKEN }}
4753
run: |
4854
DRY_RUN=$([ -z "${{ inputs.dryRun }}" ] && echo "" || echo "--dry-run")
49-
node scripts/create-node-pr.js "${{ inputs.spec }}" "$DRY_RUN"
55+
node scripts/create-node-pr.js ${{ inputs.spec }} ${{ inputs.branch }} "$DRY_RUN"

DEPENDENCIES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -551,6 +551,9 @@ graph LR;
551551
npm-->read-package-json;
552552
npm-->read;
553553
npm-->readdir-scoped-modules;
554+
npm-->remark-gfm;
555+
npm-->remark-github;
556+
npm-->remark;
554557
npm-->rimraf;
555558
npm-->semver;
556559
npm-->smoke-tests;

0 commit comments

Comments
 (0)