Skip to content

Commit 7e4e016

Browse files
committed
fix: reuse parsed options
1 parent 5cf24b5 commit 7e4e016

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

bin/semver.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ let rtl = false
2424
let identifier
2525

2626
const semver = require('../')
27+
const parseOptions = require('../internal/parse-options')
2728

2829
let reverse = false
2930

@@ -88,7 +89,7 @@ const main = () => {
8889
}
8990
}
9091

91-
options = { loose: loose, includePrerelease: includePrerelease, rtl: rtl }
92+
options = parseOptions({ loose, includePrerelease, rtl })
9293

9394
versions = versions.map((v) => {
9495
return coerce ? (semver.coerce(v, options) || { version: v }).version : v

classes/comparator.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,6 @@ class Comparator {
7878
throw new TypeError('a Comparator is required')
7979
}
8080

81-
if (!options || typeof options !== 'object') {
82-
options = {
83-
loose: !!options,
84-
includePrerelease: false,
85-
}
86-
}
87-
8881
if (this.operator === '') {
8982
if (this.value === '') {
9083
return true

functions/parse.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ const SemVer = require('../classes/semver')
44

55
const parseOptions = require('../internal/parse-options')
66
const parse = (version, options) => {
7-
options = parseOptions(options)
8-
97
if (version instanceof SemVer) {
108
return version
119
}
@@ -18,6 +16,7 @@ const parse = (version, options) => {
1816
return null
1917
}
2018

19+
options = parseOptions(options)
2120
const r = options.loose ? re[t.LOOSE] : re[t.FULL]
2221
if (!r.test(version)) {
2322
return null

0 commit comments

Comments
 (0)