fix(types): remove partial/buggy exports support (#105)

Author: wraithgar

read-json.js

@@ -521,12 +521,30 @@ function final (file, data, log, strict, cb) {
 
 function fillTypes (file, data, cb) {
   var index = data.main ? data.main : 'index.js'
-  if (data.exports && typeof data.exports === 'string') {
-    index = data.exports
-  }
-  if (data.exports && data.exports['.']) {
-    index = data.exports['.']
-  }
+
+  // TODO exports is much more complicated than this in verbose format
+  // We need to support for instance
+
+  // "exports": {
+  //   ".": [
+  //     {
+  //       "default": "./lib/npm.js"
+  //     },
+  //     "./lib/npm.js"
+  //   ],
+  //   "./package.json": "./package.json"
+  // },
+  // as well as conditional exports
+
+  // if (data.exports && typeof data.exports === 'string') {
+  //   index = data.exports
+  // }
+
+  // if (data.exports && data.exports['.']) {
+  //   index = data.exports['.']
+  //   if (typeof index !== 'string') {
+  //   }
+  // }
 
   var extless =
     path.join(path.dirname(index), path.basename(index, path.extname(index)))

test/fill-types.js

@@ -69,7 +69,7 @@ t.test('does not add types fields if not present', t => {
 
 // https://nodejs.org/api/esm.html#esm_writing_dual_packages_while_avoiding_or_minimizing_hazards
 
-t.test('handles esm modules', t => {
+t.skip('handles esm modules', t => {
   const fixture = resolve(__dirname, 'fixtures/types/esmodule-exports/exports.json')
   read(fixture, (er, data) => {
     if (er) {
@@ -85,7 +85,7 @@ t.test('handles esm modules', t => {
 
 // https://nodejs.org/api/esm.html#esm_exports_sugar
 
-t.test('handles esm modules with sugared exports', t => {
+t.skip('handles esm modules with sugared exports', t => {
   const fixture = resolve(__dirname, 'fixtures/types/esmodule-exports-sugar/sugar.json')
   read(fixture, (er, data) => {
     if (er) {