don't highlight fast, just apply to namespace, safer win_set_hl

Author: alex-courtis

lua/nvim-tree/appearance.lua

@@ -208,7 +208,7 @@ function M.setup()
     vim.api.nvim_command("hi def link " .. from .. " " .. to)
   end
 
-  -- window namespace; these don't appear to be cleared on colorscheme however err on the side of caution
+  -- window standard; this doesn't appear to clear on ColorScheme however we err on the side of caution
   for from, to in pairs(NS_LINKS) do
     vim.api.nvim_set_hl(M.NS_ID, from, { link = to })
   end

lua/nvim-tree/renderer/builder.lua

@@ -283,7 +283,6 @@ function Builder:_create_combined_group(groups)
     end
 
     -- highlight directly in the namespace
-    vim.api.nvim_set_hl_ns_fast(appearance.NS_ID)
     vim.api.nvim_set_hl(appearance.NS_ID, combined_name, combined_hl)
 
     table.insert(self.combined_groups, combined_name)

lua/nvim-tree/view.lua

@@ -135,7 +135,9 @@ local function set_window_options_and_buffer()
     vim.opt_local[k] = v
   end
   vim.opt.eventignore = eventignore
-  vim.api.nvim_win_set_hl_ns(0, appearance.NS_ID)
+
+  -- use highlights from the nvim_tree namespace
+  vim.api.nvim_win_set_hl_ns(M.get_winnr(), appearance.NS_ID)
 end
 
 ---@return table