Skip to content

feat(movement): allow circular movement for sibling next and prev #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

kyazdani42
Copy link
Member

No description provided.

@kyazdani42 kyazdani42 requested a review from alex-courtis July 11, 2022 13:46
@kyazdani42 kyazdani42 force-pushed the feat/allow-circular-for-siblings branch from 71ec2c2 to 56f0eac Compare July 11, 2022 13:49
@kyazdani42 kyazdani42 force-pushed the feat/add-mark-navigation branch from 3946730 to 5a5ab47 Compare July 11, 2022 14:55
@kyazdani42 kyazdani42 force-pushed the feat/allow-circular-for-siblings branch from 56f0eac to ff84649 Compare July 11, 2022 14:56
@kyazdani42 kyazdani42 changed the base branch from feat/add-mark-navigation to master July 11, 2022 14:56
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK:

  • root
  • 0, 1, n siblings
  • variety of folder structures

Not sure about always circular movement. nowrapscan people like me might want an option to disable, however we can add that later if requested.

@kyazdani42 kyazdani42 merged commit b32c883 into master Jul 16, 2022
@kyazdani42 kyazdani42 deleted the feat/allow-circular-for-siblings branch July 16, 2022 08:39
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants