Skip to content

feat(#2092): add api.node.navigate.open.next, prev #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

alex-courtis
Copy link
Member

fixes #2092

api.node.navigate.diagnostics.prev()
Navigate to the next item showing diagnostic status.

api.node.navigate.open.next() *nvim-tree.api.navigate.open.next()*
Copy link
Collaborator

@gegoune gegoune Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if open is a good name here. It sorta points toward action rather than a state, such as diagnostics or git. I don't have a better idea though. opened, buffers or more verbose like opened_buffers, listed_buffers. Not sure.

Copy link
Member Author

@alex-courtis alex-courtis Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listed_buffers

That's factual and exactly what we are testing for. Updated.

Edit: listed_buffers looked a bit odd, used just listed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not right... changed to opened to match highlight_opened_files.

Clarified that both of these actually show bufloaded().

Noted that filters.no_buffer uses buflisted(), however that could be considered a breaking change and may also have side effects RE buffer unloading.

@alex-courtis alex-courtis merged commit 0c9bfe7 into master Apr 3, 2023
@alex-courtis alex-courtis deleted the 2092-next-prev-open branch April 3, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node.navigate.open.next, prev
2 participants