fix(#1697): remove notify plugin auto-detection #2135
Conversation
lua/nvim-tree/notify.lua
Outdated
| else | ||
| vim.notify(string.format("[NvimTree] %s", vim.inspect(msg)), level) | ||
| end | ||
| vim.notify(msg, level, { title = "NvimTree" }) |
There was a problem hiding this comment.
There is obviously one downside of that meaning that by default opt table is unused so users won't know where that notification comes from unless they customize their vim.notify to prepend the title like it was done before.
Now, I am quite new in the vim ecosystem so it is hard for me to make a call whether that is ok, but as far as I know passing title within the opt table is kind of convention already.
There was a problem hiding this comment.
as far as I know passing title within the
opttable is kind of convention already.
It seems to be used by a few. We could safely add more info later, if a new consumer arrives.
lua/nvim-tree/notify.lua
Outdated
| else | ||
| vim.notify(string.format("[NvimTree] %s", vim.inspect(msg)), level) | ||
| end | ||
| vim.notify(msg, level, { title = "NvimTree" }) |
There was a problem hiding this comment.
as far as I know passing title within the
opttable is kind of convention already.
It seems to be used by a few. We could safely add more info later, if a new consumer arrives.
alex-courtis
changed the title
fixes #1697
This PR is a direct consequence of the discussion that took place in #2117
This addresses the issue #1697 because users can just customize their
vim.notifyhandlers.