fix(#1545): dispatch Event.Resize on all window resizes, requires nvim 0.9+ #2238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gegoune
reviewed
May 28, 2023
| if vim.fn.has "nvim-0.9" == 1 then | ||
| create_nvim_tree_autocmd("WinResized", { | ||
| callback = function() | ||
| if vim.v.event and vim.v.event.windows then |
There was a problem hiding this comment.
Not sure if it makes any difference but fallback receives an event afair.
There was a problem hiding this comment.
Do you mean the fallback in view.lua?
Sending multiple events would be undesirable...
There was a problem hiding this comment.
Do you mean the fallback in view.lua?
Sending multiple events would be undesirable...
No, meant that you should be able to do
callback = function(event)There was a problem hiding this comment.
Of course, I'll give that a go.
There was a problem hiding this comment.
Unfortunately no. The v:event data is still not passed to the callback. I hope they add that at some point...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1545
@wlh320 @Tcholly I'd be most grateful if you tested this fix:
cd /path/to/nvim-tree.lua git pull git checkout 1545-resize-events