Skip to content

feat: split warning messages into multiple lines #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

Akmadan23
Copy link
Collaborator

Now that notifications are scheduled, having multiple line messages should not be an issue anymore. This way warnings are far easier to read.

@alex-courtis
Copy link
Member

Works nicely for nvim-notify:

      ╭──────────────────────────────────────────────────────────────╮
~     │  NvimTree                                          12:45:31 │
~     │━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━│
~     │[NvimTree]                                                    │
~     │Invalid option: ui.confirm.trash. Expected boolean, got string│
~     │Invalid value for field view.side: 'bottom'                   │
~     │                                                              │
~     │see :help nvim-tree-opts for available configuration options  │
~     ╰──────────────────────────────────────────────────────────────╯

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great as it also gets us around the silly neovim/neovim#17832 problem which has been hiding startup messages.

Keep up the great work @Akmadan23 !

@alex-courtis alex-courtis merged commit 113e095 into master Oct 1, 2023
@alex-courtis alex-courtis deleted the split-warning-messages branch October 1, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants