fix: Fixed "BiB" bug and improved binary prefixes #2492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now there is a whitespace between value and unit. - Now values >= 1024 YiB are shown in YiB instead of B. - To reuse same code a new local function was added: round().
Andrew15-5
changed the title
Andrew15-5
changed the title
|
I also created a separate |
That's fine, round should be private i.e. not a member of utils |
alex-courtis
approved these changes
Oct 22, 2023
|
Oh, right, I forgot to mention this (now fixed):
|
Many thanks. I'm quite happy with the results. |
alex-courtis
added a commit
that referenced
this pull request
Oct 30, 2023
) * fix(#2467): remove newline in git paths * fix: info size suffix and formatting (#2492) - Now there is a whitespace between value and unit. - Now values >= 1024 YiB are shown in YiB instead of B. - To reuse same code a new local function was added: round(). * feat(#2312): fire `TextYankPost` event on path copy (#2489) * feat(#2312): fire `TextYankPost` event on path copy * stylua * Bug fix --------- Co-authored-by: Alexander Courtis <[email protected]> * feat: mapping and options to sort entries in help window (#2482) * feat: add option to sort entries in help window * stylua * Add keymap to toggle sorting methods * Bug fix --------- Co-authored-by: Alexander Courtis <[email protected]> * fix(#2467): remove newline in git paths * fix(#2467): change cygpath calls to array format To avoid shell compatibility issues in msys2 environment on Windows * stylua nit --------- Co-authored-by: Alexander Courtis <[email protected]> Co-authored-by: Andrew Voynov <[email protected]> Co-authored-by: Azad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new patch after #2483.
What's new:
I've also added comments to clarify some things. The
round()function is local, but the plugin works correctly (I thought it wouldn't). I don't know how exactlyMfromutils.luais used, so I didn't doM.round().