-
-
Notifications
You must be signed in to change notification settings - Fork 626
feat(#2515): add option to change grouped folders name with custom function #2521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/nvim-tree-lua.txt
Outdated
@@ -795,7 +795,10 @@ Appends a trailing slash to folder names. | |||
|
|||
*nvim-tree.renderer.group_empty* | |||
Compact folders that only contain a single folder into one node. | |||
Type: `boolean`, Default: `false` | |||
Can be a custom function that takes one argument (the relative path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be a custom function that takes one argument (the relative path | |
Boolean or a function that takes single argument (the relative path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with all the corrections, I would just leave "one" instead of "single" since it's more consistent with two other occurrences of something like "the function takes one argument" throughout the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, consistency is the key. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit pick on documentation. Let's keep it impersonal and as short as possible while conveying necessary meaning.
Thanks for that PR! Interested to see what people will come up with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, tested OK:
- false
- "invalid"
- function returning number
- function returning nil
- function returning hardcoded string
- function returning decorated
Closes #2515