Skip to content

Commit 517ebab

Browse files
wolfy1339styfleprettier-toc-me[bot]renovate[bot]kfcampbell
authored
feat: v7 (#586)
* ci: stop testing against NodeJS v14, v16 (#581) BREAKING CHANGE: Drop support for NodeJS v14, v16 * feat: remove `node-fetch` in favor of global (#580) BREAKING CHANGE: remove `node-fetch` in favor of global * docs: update ToC for README.md * fix(deps): update dependency @octokit/request-error to v4 (#587) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: bump `@octokit/request-error` * fix(deps): bump `@octokit/types` * fix(build): bump Octokit deps * tests: adapt for `@octokit/endpoint` v8 * fix(deps): upgrade to `@octokit/endpoint` v8 stable --------- Co-authored-by: Steven <[email protected]> Co-authored-by: prettier-toc-me[bot] <56236715+prettier-toc-me[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Keegan Campbell <[email protected]>
1 parent 62f51d6 commit 517ebab

File tree

8 files changed

+237
-5484
lines changed

8 files changed

+237
-5484
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@ jobs:
1414
strategy:
1515
matrix:
1616
node_version:
17-
- 14
18-
- 16
1917
- 18
18+
- 20
2019
steps:
2120
- uses: actions/checkout@v3
2221
- name: Use Node.js ${{ matrix.node_version }}

README.md

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ to interact with [GitHub’s REST API](https://developer.github.com/v3/) and
1010
[GitHub’s GraphQL API](https://developer.github.com/v4/guides/forming-calls/#the-graphql-endpoint).
1111

1212
It uses [`@octokit/endpoint`](https://github.com/octokit/endpoint.js) to parse
13-
the passed options and sends the request using [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API)
14-
([node-fetch](https://github.com/bitinn/node-fetch) when the runtime has no native `fetch` API).
13+
the passed options and sends the request using [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API). You can pass a custom `fetch` function using the `options.request.fetch` option, see below.
1514

1615
<!-- update table of contents by running `npx markdown-toc README.md -i` -->
1716

@@ -319,7 +318,7 @@ const { data: app } = await requestWithAuth(
319318
Function
320319
</td>
321320
<td>
322-
Custom replacement for <a href="https://github.com/bitinn/node-fetch">built-in fetch method</a>. Useful for testing or request hooks.
321+
Custom replacement for <a href="https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API">fetch</a>. Useful for testing or request hooks.
323322
</td>
324323
</tr>
325324
<tr>
@@ -354,17 +353,6 @@ const { data: app } = await requestWithAuth(
354353
Used for internal logging. Defaults to <a href="https://developer.mozilla.org/en-US/docs/Web/API/console"><code>console</code></a>.
355354
</td>
356355
</tr>
357-
<tr>
358-
<th align=left>
359-
<code>options.request.timeout</code>
360-
</th>
361-
<td>
362-
Number
363-
</td>
364-
<td>
365-
Node only. Request/response timeout in ms, it resets on redirect. 0 to disable (OS limit applies). <a href="#options-request-signal">options.request.signal</a> is recommended instead.
366-
</td>
367-
</tr>
368356
</table>
369357

370358
All other options except `options.request.*` will be passed depending on the `method` and `url` options.

0 commit comments

Comments
 (0)