Skip to content

Commit 33dc77e

Browse files
Uzlopakwolfy1339
andauthored
ci: stop testing against NodeJS v18 & fix sign benchmark (#330)
BREAKING CHANGE: Drop support for NodeJS v18 --------- Co-authored-by: wolfy1339 <[email protected]> Co-authored-by: wolfy1339 <[email protected]>
1 parent 4ad19a6 commit 33dc77e

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ jobs:
5252
fail-fast: false
5353
matrix:
5454
node_version:
55-
- 18
5655
- 20
5756
- 22
57+
- 24
5858
steps:
5959
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
6060
- name: Use Node.js ${{ matrix.node_version }}
@@ -74,6 +74,8 @@ jobs:
7474
- browser
7575
steps:
7676
- run: exit 1
77-
if: ${{ needs.lint.result != 'success' || needs.node.result != 'success' || needs.browser.result != 'success' || needs.deno.result != 'success' }}
77+
if:
78+
${{ needs.lint.result != 'success' || needs.node.result != 'success' ||
79+
needs.browser.result != 'success' || needs.deno.result != 'success' }}
7880
- run: echo ok
7981
if: ${{ always() }}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,6 @@
7373
]
7474
},
7575
"engines": {
76-
"node": ">= 18"
76+
"node": ">= 20"
7777
}
7878
}

scripts/build.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ async function main() {
3030
outdir: "pkg/dist-node",
3131
bundle: true,
3232
platform: "node",
33-
target: "node18",
33+
target: "node20",
3434
format: "esm",
3535
...sharedOptions,
3636
}),

test/benchmark-sign.bench.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { bench, describe } from "vitest";
2-
import { verify as verifyNode } from "../src/index.ts";
3-
import { verify as verifyWeb } from "../src/web.ts";
2+
import { sign as signNode } from "../src/index.ts";
3+
import { sign as signWeb } from "../src/web.ts";
44
import { toNormalizedJsonString } from "./common.ts";
55

66
describe("sign", () => {

0 commit comments

Comments
 (0)