Skip to content

Commit f15ec13

Browse files
lunndavem330
authored andcommitted
net: dsa: Make use of devlink port flavour unused
If a port is unused, still create a devlink port for it, but set the flavour to unused. This allows us to attach devlink regions to the port, etc. Reviewed-by: Vladimir Oltean <[email protected]> Tested-by: Vladimir Oltean <[email protected]> Signed-off-by: Andrew Lunn <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent cf11663 commit f15ec13

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

net/dsa/dsa2.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,15 @@ static int dsa_port_setup(struct dsa_port *dp)
272272

273273
switch (dp->type) {
274274
case DSA_PORT_TYPE_UNUSED:
275+
memset(dlp, 0, sizeof(*dlp));
276+
attrs.flavour = DEVLINK_PORT_FLAVOUR_UNUSED;
277+
devlink_port_attrs_set(dlp, &attrs);
278+
err = devlink_port_register(dl, dlp, dp->index);
279+
if (err)
280+
break;
281+
282+
devlink_port_registered = true;
283+
275284
dsa_port_disable(dp);
276285
break;
277286
case DSA_PORT_TYPE_CPU:
@@ -355,6 +364,7 @@ static void dsa_port_teardown(struct dsa_port *dp)
355364

356365
switch (dp->type) {
357366
case DSA_PORT_TYPE_UNUSED:
367+
devlink_port_unregister(dlp);
358368
break;
359369
case DSA_PORT_TYPE_CPU:
360370
dsa_port_disable(dp);

0 commit comments

Comments
 (0)