Skip to content

Commit e05193f

Browse files
anjgolaJoeOster
andauthored
Add pull request template (#61)
* Update CODEOWNERS * Update dpc_common.hpp * Update dpc_common.hpp * Create PULL_REQUEST_TEMPLATE * Rename PULL_REQUEST_TEMPLATE to PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md Co-authored-by: JoeOster <[email protected]>
1 parent a798f0a commit e05193f

File tree

1 file changed

+40
-0
lines changed

1 file changed

+40
-0
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# Description
2+
3+
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
4+
5+
Fixes # (issue)
6+
7+
## Type of change
8+
9+
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
10+
11+
- [ ] Bug fix (non-breaking change which fixes an issue)
12+
- [ ] New feature (non-breaking change which adds functionality)
13+
- [ ] Sample Migration (Moving sample from old repository after completing checklist established)
14+
15+
# How Has This Been Tested?
16+
17+
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
18+
19+
- [ ] Command Line
20+
- [ ] oneapi-cli
21+
- [ ] Visual Studio
22+
- [ ] Eclipse IDE
23+
- [ ] VSCode
24+
25+
# Checklist for Moving samples:
26+
Links and Details can be found in the samples WG Teams Files.
27+
28+
- [ ] Review sample design with domain reviewers https://github.com/oneapi-src/oneAPI-samples/wiki/Reviewers-and-Domain-Experts
29+
- [ ] Implement coding guidelines and ensure code quality.
30+
- [ ] Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
31+
- [ ] Run jsonlint on sample.json to verify json syntax. www.jsonlint.com
32+
- [ ] Adhere to readme template
33+
- [ ] Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
34+
- [ ] Enforce format via clang-format config file
35+
- [ ] Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
36+
- [ ] Review readme with Tom Lenth or Joe Oster. (GitHub User: JoeOster)
37+
- [ ] Tested using Dev Cloud when applicable
38+
- [ ] Implement fixes for ONSAM Jiras
39+
- [ ] If you have new dependencies/binaries, inform Samples Project Manager Swapna R Dontharaju (@srdontha) or @JoeOster
40+

0 commit comments

Comments
 (0)